backup and retrieval added #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@opticod Please review if this works fine. |
|
@dabbler011, will review it shortly. |
opticod
approved these changes
Jan 30, 2018
There was a problem hiding this comment.
Very good progress!
I am merging this PR. But there are few required changes to be made, you can incorporate those in new PRs.
- Showing some dialog progress box, when the backup is going on.
- When there are no drive screens, on Backuping, the app crashes.
- Place the backup icon on the drive screen, not in the navigation sidebar.
- There is HTTP leak while backuping the data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3
Firebase backup added.