PSO Speed up #221
Closed
PSO Speed up #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NicerNewerCar
commented
Oct 25, 2023
•
NicerNewerCar
commented
- Closes How possible is it to run the particle optimization in parallel? #218
- Initial results are great, cutting the optimization time to 5/6 seconds [Debug] 2/3 seconds [Release] on my machine
- Currently, I am validating the accuracy of this. I've noticed sometimes it likes to optimize to a nonideal position (ie. not in the correct position on the radiograph). Not sure if this is an issue with my changes or something pre-existing.
- @amymmorton @jcfr If you both could play around with this PR, that may help expedite the validation process.
NicerNewerCar
force-pushed
the
parallel-pso
branch
3 times, most recently
from
00181de to
d9fa295
Compare
jcfr
reviewed
Oct 25, 2023
There was a problem hiding this comment.
Moving in that direction makes sense 👌
Could you contribute the API changes (introduction of Particle and vector of Particle) into its own pull request ?
That way the pull request introducing the threading support will be reduce to its strict minimum and the review will be easier.
|
See #223 Rebase this branch once that is integrated. |
* For any given particle p, this update removes any recomputation of the NCC fitness value. * Replaces arrays with vectors * This drops the per frame opt time from ~9 to ~18 seconds to around ~3 seconds
NicerNewerCar
force-pushed
the
parallel-pso
branch
from
d9fa295 to
63dd82e
Compare
|
Rebased this with #223, Seems some of the errors I corrected over there led to this not being as fast. 223 Runs in 3-5 seconds while adding the multithreading added enough overhead that it actually slowed this down to 8-9 seconds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.