-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Ensure CUDA RayCaster is sets visible to true by default #251
Conversation
Bug was introduced in commit 73eb359
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amymmorton I also wonder if this is an issue with the MATLAB socket lib, could you try running the Python script below with your data to see if the issue persists? Using the following Python script I can successfully load data with the socket into the latest CUDA main branch (tested with WN00113): from PyAutoscoper.connect import AutoscoperConnection
ac = AutoscoperConnection()
ac.loadTrial(MY_TRIAL_PATH)
ac.loadFilters(0, MY_FILTER_PATH)
ac.loadFilters(1, MY_FILTER_PATH) |
The most recent test was on implant data - so it seems consistent
across data sets.
Entirely plausible it's a matlab socket issue - will test python
…On Wed, Jan 17, 2024 at 9:47 AM Anthony Lombardi ***@***.***> wrote:
@amymmorton <https://github.com/amymmorton>
I am having a hard time reproducing this problem. Is this happening with
just a specific dataset or any of them?
I also wonder if this is an issue with the MATLAB socket lib, could you
try running the Python script below with your data to see if the issue
persists?
Using the following Python script I can successfully load data with the
socket into the latest CUDA main branch (tested with WN00113):
from PyAutoscoper.connect import AutoscoperConnectionac = AutoscoperConnection()ac.loadTrial(MY_TRIAL_PATH)ac.loadFilters(0, MY_FILTER_PATH)ac.loadFilters(1, MY_FILTER_PATH)
image.png (view on web)
<https://github.com/BrownBiomechanics/Autoscoper/assets/30351234/7a90512d-f066-4c7a-a15d-d9a38f972661>
—
Reply to this email directly, view it on GitHub
<#251 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APUUPFQOC5JFQMKDE7AJWI3YO7QBHAVCNFSM6AAAAABB6SE6KGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJVHE3DGOBSGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
-----------
Amy Morton, MSc
Sr. Research Engineer, Bioengineering Lab, Department of Orthopaedic
Research
The Warren Alpert Medical School of Brown University and Rhode Island
Hospital
1 Hoppin Street, CORO West, Ste. 404, Providence, RI 02903
|
Also - I had been using the -1 input parameter with loadFilter for all
volumes
loadFilters(aobj,-1,fullfile(d_subj,'xParameters','control_settings.vie'));
…On Wed, Jan 17, 2024 at 9:50 AM Morton, Amy ***@***.***> wrote:
The most recent test was on implant data - so it seems consistent
across data sets.
Entirely plausible it's a matlab socket issue - will test python
On Wed, Jan 17, 2024 at 9:47 AM Anthony Lombardi ***@***.***>
wrote:
> @amymmorton <https://github.com/amymmorton>
> I am having a hard time reproducing this problem. Is this happening with
> just a specific dataset or any of them?
>
> I also wonder if this is an issue with the MATLAB socket lib, could you
> try running the Python script below with your data to see if the issue
> persists?
>
> Using the following Python script I can successfully load data with the
> socket into the latest CUDA main branch (tested with WN00113):
>
> from PyAutoscoper.connect import AutoscoperConnectionac = AutoscoperConnection()ac.loadTrial(MY_TRIAL_PATH)ac.loadFilters(0, MY_FILTER_PATH)ac.loadFilters(1, MY_FILTER_PATH)
>
> image.png (view on web)
> <https://github.com/BrownBiomechanics/Autoscoper/assets/30351234/7a90512d-f066-4c7a-a15d-d9a38f972661>
>
> —
> Reply to this email directly, view it on GitHub
> <#251 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/APUUPFQOC5JFQMKDE7AJWI3YO7QBHAVCNFSM6AAAAABB6SE6KGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJVHE3DGOBSGY>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
-----------
Amy Morton, MSc
Sr. Research Engineer, Bioengineering Lab, Department of Orthopaedic
Research
The Warren Alpert Medical School of Brown University and Rhode Island
Hospital
1 Hoppin Street, CORO West, Ste. 404, Providence, RI 02903
--
-----------
Amy Morton, MSc
Sr. Research Engineer, Bioengineering Lab, Department of Orthopaedic
Research
The Warren Alpert Medical School of Brown University and Rhode Island
Hospital
1 Hoppin Street, CORO West, Ste. 404, Providence, RI 02903
|
I am not sure that this behavior is defined, since the first parameter should be the camera id not the volume id. |
Yes - sorry for both cameras
…On Wed, Jan 17, 2024 at 9:59 AM Anthony Lombardi ***@***.***> wrote:
Also - I had been using the -1 input parameter with loadFilter for all
volumes
loadFilters(aobj,-1,fullfile(d_subj,'xParameters','control_settings.vie'));
I am not sure that this behavior is defined, since the first parameter
should be the camera id
<https://autoscoper.readthedocs.io/en/latest/socket-control-libraries/pyautoscoper.html#PyAutoscoper.connect.AutoscoperConnection.loadFilters>
not the volume id.
Within pyautoscoper we are forcing this value to be an unsigned int (>= 0)
—
Reply to this email directly, view it on GitHub
<#251 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APUUPFS5Z7RJ3KFJRT4VNXTYO7RNJAVCNFSM6AAAAABB6SE6KGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJVHE4DQNRRGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
-----------
Amy Morton, MSc
Sr. Research Engineer, Bioengineering Lab, Department of Orthopaedic
Research
The Warren Alpert Medical School of Brown University and Rhode Island
Hospital
1 Hoppin Street, CORO West, Ste. 404, Providence, RI 02903
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once @amymmorton confirmed
this will be ready for integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending @amymmorton review
Considering this was approved by @amymmorton , moving forward with integration |
Bug was introduced in commit 73eb359