Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Ensure CUDA RayCaster is sets visible to true by default #251

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

NicerNewerCar
Copy link
Contributor

Bug was introduced in commit 73eb359

Copy link
Collaborator

@amymmorton amymmorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On load via socket the drr checboxes are true but the volume is not visible

cudaFalse

@NicerNewerCar
Copy link
Contributor Author

@amymmorton
I am having a hard time reproducing this problem. Is this happening with just a specific dataset or any of them?

I also wonder if this is an issue with the MATLAB socket lib, could you try running the Python script below with your data to see if the issue persists?

Using the following Python script I can successfully load data with the socket into the latest CUDA main branch (tested with WN00113):

from PyAutoscoper.connect import AutoscoperConnection
ac = AutoscoperConnection()
ac.loadTrial(MY_TRIAL_PATH)
ac.loadFilters(0, MY_FILTER_PATH)
ac.loadFilters(1, MY_FILTER_PATH)

image

@amymmorton
Copy link
Collaborator

amymmorton commented Jan 17, 2024 via email

@amymmorton
Copy link
Collaborator

amymmorton commented Jan 17, 2024 via email

@NicerNewerCar
Copy link
Contributor Author

Also - I had been using the -1 input parameter with loadFilter for all volumes loadFilters(aobj,-1,fullfile(d_subj,'xParameters','control_settings.vie'));

I am not sure that this behavior is defined, since the first parameter should be the camera id not the volume id.
Within pyautoscoper we are forcing this value to be an unsigned int (>= 0)

@amymmorton
Copy link
Collaborator

amymmorton commented Jan 17, 2024 via email

Copy link
Collaborator

@amymmorton amymmorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building fresh again today (01/22/2024). Confirmed line change 69 RayCaster.

pre_connectAndLoad

Confirmed DRR visible at load in Py socket on single trial.
post_run_AutSocketAMMPy

Also confirm drr visible on iterative cfg load:
iter_pyload

AMM todo:

  • matlab apply filter each cam independent to confirm the visibility of the drr.

@jcfr
Copy link
Contributor

jcfr commented Feb 5, 2024

Once @amymmorton confirmed

matlab apply filter each cam independent to confirm the visibility of the drr.

this will be ready for integration

Copy link
Contributor

@jcfr jcfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending @amymmorton review

@jcfr
Copy link
Contributor

jcfr commented Feb 5, 2024

Considering this was approved by @amymmorton , moving forward with integration

@jcfr jcfr merged commit 1bae922 into BrownBiomechanics:main Feb 5, 2024
3 checks passed
@NicerNewerCar NicerNewerCar deleted the cuda-vis-fix branch February 5, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants