ENH: Load combined scale and translation transforms to generated PVs #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amymmorton
approved these changes
Nov 11, 2024
jcfr
requested changes
Nov 11, 2024
sbelsk
force-pushed
the
declutter-loaded-tfms-for-pvs
branch
2 times, most recently
from
4fafd67 to
b778159
Compare
jcfr
approved these changes
Nov 20, 2024
To reduce clutter for the app users, after the generation of partial
volumes in the pre-processing module, only the combined scale and
translation transformation layer is loaded and applied onto each PV,
instead of the two separate scale and translation trasnforms. I.e.,
`{}.tfm` is loaded and applied instead of `{}_t.ftm` and `{}_scale.tfm`.
All files are still written to the output directory as part of the PV
generation proceess as before.
Co-authored-by: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>
jcfr
force-pushed
the
declutter-loaded-tfms-for-pvs
branch
from
b778159 to
073925a
Compare
jcfr
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #133
To reduce clutter for the app users, after the generation of partial volumes in the pre-processing module, only the combined scale and translation transformation layer is loaded and applied onto each PV, instead of the two separate scale and translation trasnforms. I.e.,
{}.tfmis loaded and applied instead of{}_t.ftmand{}_scale.tfm.All files are still written to the output directory as part of the PV generation proceess as before.