ENH: Collapse 'Advanced' Pre-Processing menu by default #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'Advanced Options' menu in the Pre-Processing module is still toggleable, but is now rendered as collapsed by default on module launch.
|
Noting that this change will be superseded by the UI overhaul in #141, @amymmorton would you like this change to merge first anyway, or should we discard this PR and instead implement the request from #145 in #141 (e.g., by rendering the "Default Subdirectories" group as collapsed by default)? |
|
Great point- we can discard (sorry!) in favor of 141
…On Wed, Nov 20, 2024 at 10:44 AM Shelly Belsky ***@***.***> wrote:
Noting that this change will be superseded by the UI overhaul in #141
<#141>,
@amymmorton <https://github.com/amymmorton> would you like this change to
merge first anyway, or should we discard this PR and instead implement the
request from #145
<#145> in
#141 <#141>
(e.g., by rendering the "Default Subdirectories" group as collapsed by
default)?
—
Reply to this email directly, view it on GitHub
<#146 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APUUPFWX7MZQNFFNA3EEUSL2BSU5NAVCNFSM6AAAAABRW4MDS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOBYHEZTCNRSGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
-----------
Amy Morton MSc
*Senior Research Engineer*
*Brown University Healt**h*
Orthopaedic Research, 1 Hoppin Street, Coro West, 4th
Providence, RI 02903-4923
linkedin <https://www.linkedin.com/in/amy-morton-35374340/>
|
|
Closing in favor of #141. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #145.
The 'Advanced Options' menu in the Pre-Processing module is still toggleable, but is now rendered as collapsed by default on module launch.