Conversation
added 3 commits
October 24, 2024 00:03
…орых аргументов выставлены default значения
12gerts
reviewed
Nov 2, 2024
Collaborator
12gerts
left a comment
12gerts
left a comment
There was a problem hiding this comment.
Да здравствует наследование! Код надо переиспользовать
bot_logic.py
Outdated
| return random.choice(available_moves) | ||
|
|
||
|
|
||
| def check_winner(grid_size: int, grid: List[List[Optional[str]]], row: int, col: int) -> bool: |
Collaborator
There was a problem hiding this comment.
Это старая типизация. С 3.11 не надо импортировать из typing
Suggested change
| def check_winner(grid_size: int, grid: List[List[Optional[str]]], row: int, col: int) -> bool: | |
| def check_winner(grid_size: int, grid: list[list[str | None]], row: int, col: int) -> bool: |
bot_logic.py
Outdated
| return best_move | ||
|
|
||
| # 5. Если нет угроз и победных ходов, делаем случайный ход | ||
| available_moves: List[Tuple[int, int]] = [(x, y) for x in range(grid_size) for y in range(grid_size) |
Collaborator
There was a problem hiding this comment.
Не понимаю, зачем вы складываете это в кортеж, потом распаковываете, а потом опять собираете в кортеж. Можно это просто будет сразу какая-то структура, с которой везде будете работать
bot_logic.py
Outdated
| return None | ||
|
|
||
|
|
||
| def bot_move(grid_size, grid, bot_color, player_color) -> Tuple[int, int]: |
bot_logic.py
Outdated
|
|
||
| for dr, dc in _DIRECTIONS: | ||
| count: int = 1 | ||
| for i in range(1, 5): |
button.py
Outdated
| is_transparent: bool, obj: Optional[str], text: str = '') -> None: | ||
| function: Callable, args=None, | ||
| color=(0, 0, 0), hover_color=(0, 0, 0), on_close=False, | ||
| is_transparent=False, obj=None, text='') -> None: |
classic_game.py
Outdated
Comment on lines
118
to
122
| current_time = time.time() | ||
| elapsed = current_time - self._last_time | ||
| if elapsed >= 1: # Обновляем каждую секунду | ||
| self._total_time -= int(elapsed) # Уменьшаем общий таймер | ||
| self._player_time -= int(elapsed) # Уменьшаем таймер игрока |
Collaborator
There was a problem hiding this comment.
Давайте datetime
from datetime import datetime
Suggested change
| current_time = time.time() | |
| elapsed = current_time - self._last_time | |
| if elapsed >= 1: # Обновляем каждую секунду | |
| self._total_time -= int(elapsed) # Уменьшаем общий таймер | |
| self._player_time -= int(elapsed) # Уменьшаем таймер игрока | |
| current_time = datetime.now() | |
| elapsed = current_time - self._last_time | |
| if elapsed >= 1: # Обновляем каждую секунду | |
| self._total_time -= elapsed.seconds # Уменьшаем общий таймер | |
| self._player_time -= elapsed.seconds # Уменьшаем таймер игрока |
n_enemies.py
Outdated
Comment on lines
44
to
45
| winner = pygame.transform.scale(pygame.image.load("images/winner.png"), (290, 150)) | ||
| self._robot: pygame.Surface = pygame.transform.scale(pygame.image.load("images/robot.png"), (290, 190)) |
Collaborator
There was a problem hiding this comment.
Вынесите (290, 150) и (290, 190) во что-нибудь
n_enemies.py
Outdated
| from window import Window | ||
|
|
||
|
|
||
| class NEnemiesMode: |
Collaborator
There was a problem hiding this comment.
Есть ощущение, что надо сделать интерфейс и базовый класс для этого и ClassicMode, чета слишком много общего кода
options_of_n_enemies.py
Outdated
| окна настроек. Изменения темы сохраняются в файл. | ||
| """ | ||
| themes: List[str] = ['grid0.jpg', 'grid1.jpg', 'grid2.jpg'] | ||
| theme_file = Path('setting/theme.txt') |
Collaborator
There was a problem hiding this comment.
чета какое-то бесполезное действие. вы не используете возможности pathlib и зачем-то приводите к пути на месте, так тут еще и обратно в строку конвертируете и вечно строкой везде прописываете
options_of_n_enemies.py
Outdated
| prev_theme: str = theme_file.read_text().strip() | ||
| theme_index: int = (themes.index(prev_theme) + 1) % len(themes) | ||
| theme_file.write_text(themes[theme_index]) | ||
| theme_image_path = Path('images') / themes[theme_index] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Видны отличия от старой версии