Skip to content

Refactor : error screen#21

Open
ShroukMohamed16 wants to merge 4 commits intodevelopfrom
refactor/lost-connection-screen
Open

Refactor : error screen#21
ShroukMohamed16 wants to merge 4 commits intodevelopfrom
refactor/lost-connection-screen

Conversation

@ShroukMohamed16
Copy link
Collaborator

Description

this PR updates the error screen.


Changes Made

List the changes introduced in this pull request:

  • Updated text and button styles for improved clarity.
  • Added new drawable resources for button background, progress bar, error icon, and circular background.
  • Adjusted medium radius dimension.
  • Modified string resources for error messages and button text.

Screenshots (if applicable)

image

Checklist

Please ensure the following tasks are completed:

  • I didn't change the code structure.
  • I didn't use Jetpack Compose.
  • I used the same code structure used in the original code
  • PR includes at most one code change to convert the design to CineVerse.
  • My changes have been tested manually and verified.
  • PR includes at most one single feature.

app:layout_constraintStart_toStartOf="parent"
app:layout_constraintTop_toBottomOf="@id/title_lost_connection" />

<Button
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button radius is not correct, it should be 10.dp, and I think it's a squircle shape

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double check this, I think it's correct you can see this line is using radius medium which is 10.dp

android:background="@drawable/button_background"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I think the problem is that it's a squircle shape

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes you're right I'm working to extend the style of the button in order to match the design

android:layout_width="wrap_content"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:layout_marginTop="@dimen/spacing_medium"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The margin top here should be spacing_small

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here in the button should be spacing_large

android:layout_width="wrap_content"
android:layout_width="240dp"
android:layout_height="wrap_content"
android:layout_marginTop="@dimen/spacing_medium"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But here in the TextView description it should be spacing_small to match the design

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<shape android:shape="rectangle" xmlns:android="http://schemas.android.com/apk/res/android">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the button background is selector and handle state when it's click in order to see its selection

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do I need to make it a selector?

Please make sure the button background is selector and handle state when it's click in order to see its selection

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do I need to make it a selector?

@ShroukMohamed16 in order to achieve this ripple effect when we click on the button I made it like this with ripple tag if you don't want to use selector

<ripple xmlns:android="http://schemas.android.com/apk/res/android"
    android:color="?attr/colorControlHighlight">
    <item>
        <shape android:shape="rectangle">
            <solid android:color="@color/button_primary" />
            <corners android:radius="@dimen/radius_medium" />
        </shape>
    </item>
</ripple>
Screen.Recording.2025-09-09.at.13.45.44.mov

@ShroukMohamed16 ShroukMohamed16 changed the title refactor/error-screen refactor:error-screen Sep 9, 2025
@ShroukMohamed16 ShroukMohamed16 changed the title refactor:error-screen Refactor:error-screen Sep 9, 2025
@ShroukMohamed16 ShroukMohamed16 changed the title Refactor:error-screen Refactor : error screen Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants