Conversation
| app:layout_constraintStart_toStartOf="parent" | ||
| app:layout_constraintTop_toBottomOf="@id/title_lost_connection" /> | ||
|
|
||
| <Button |
There was a problem hiding this comment.
The button radius is not correct, it should be 10.dp, and I think it's a squircle shape
There was a problem hiding this comment.
I double check this, I think it's correct you can see this line is using radius medium which is 10.dp
android:background="@drawable/button_background"
There was a problem hiding this comment.
ok, I think the problem is that it's a squircle shape
There was a problem hiding this comment.
yes you're right I'm working to extend the style of the button in order to match the design
app/src/main/res/layout/error2.xml
Outdated
| android:layout_width="wrap_content" | ||
| android:layout_width="0dp" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginTop="@dimen/spacing_medium" |
There was a problem hiding this comment.
The margin top here should be spacing_small
There was a problem hiding this comment.
I think here in the button should be spacing_large
app/src/main/res/layout/error2.xml
Outdated
| android:layout_width="wrap_content" | ||
| android:layout_width="240dp" | ||
| android:layout_height="wrap_content" | ||
| android:layout_marginTop="@dimen/spacing_medium" |
There was a problem hiding this comment.
But here in the TextView description it should be spacing_small to match the design
| @@ -0,0 +1,4 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <shape android:shape="rectangle" xmlns:android="http://schemas.android.com/apk/res/android"> | |||
There was a problem hiding this comment.
Please make sure the button background is selector and handle state when it's click in order to see its selection
There was a problem hiding this comment.
Why do I need to make it a selector?
Please make sure the button background is selector and handle state when it's click in order to see its selection
There was a problem hiding this comment.
Why do I need to make it a selector?
@ShroukMohamed16 in order to achieve this ripple effect when we click on the button I made it like this with ripple tag if you don't want to use selector
<ripple xmlns:android="http://schemas.android.com/apk/res/android"
android:color="?attr/colorControlHighlight">
<item>
<shape android:shape="rectangle">
<solid android:color="@color/button_primary" />
<corners android:radius="@dimen/radius_medium" />
</shape>
</item>
</ripple>
Description
this PR updates the error screen.
Changes Made
List the changes introduced in this pull request:
Screenshots (if applicable)
Checklist
Please ensure the following tasks are completed: