-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rejig notifications to work with layer-shell positioning #656
Conversation
Could we use anchors to set the corner of the screen selected in Budgie Desktop Settings? |
@EbonJaeger hopefully the last commit does this. Needs proper testing rather than just "notify-send" stuff that I have been using. |
Using a margin for y-axis positioning is really clever; I like it. In the calculate position function, do we still have switch cases for left and right? If so, it could likely be further simplified, since we only care about the y-axis. Left side or right side doesn't matter anymore. |
indeed - latest commit does this. |
Since the calculate function only has to return one value now, should we make the return type |
Definitely down to the bare essentials in the latest commit :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love seeing that function gutted 😃
It appears to work great for me; I sent some notifications with different position settings, and it just works. No more notifications in the middle of the screen!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Description
This PR changes from absolute positioning of windows (aka X11) to layershell positioning
Submitter Checklist
git rebase -i
(if needed)