fix: read macho size (#10)

BugSplat-Git · Jan 11, 2024 · 606f052 · 606f052
1 parent 78dbb93
commit 606f052
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/fat.ts b/src/fat.ts
@@ -61,16 +61,17 @@ export class FatFile {
             const numberOfMachos = buffer.readUInt32BE(0);
 
             for (let i = 0; i < numberOfMachos; i++) {
+                const numberOfBytesToRead = lengthOfMachoStartOffset + lengthOfMachoSize;
                 const machoStartOffset = sizeOfFatMagic + sizeOfNumberOfMachosSection + (i * lengthOfFatArchSection);
                 const machoFileOffsetOffset = machoStartOffset + lengthOfCpuType + lengthOfCpuSubType;
-                const { buffer, bytesRead } = await fileHandle.read(Buffer.alloc(lengthOfMachoStartOffset), 0, lengthOfMachoStartOffset, machoFileOffsetOffset);
+                const { buffer, bytesRead } = await fileHandle.read(Buffer.alloc(numberOfBytesToRead), 0, numberOfBytesToRead, machoFileOffsetOffset);
 
-                if (bytesRead !== lengthOfMachoStartOffset) {
+                if (bytesRead !== numberOfBytesToRead) {
                     throw new Error('Could not read Fat header.');
                 }
 
-                const machoFileOffset = buffer.readUInt32BE(0); 
-                const machoFileSize = buffer.readUInt32BE(0);
+                const machoFileOffset = buffer.readUInt32BE(0);
+                const machoFileSize = buffer.readUInt32BE(lengthOfMachoStartOffset);
                 const machoFile = new MachoFile(this.path, machoFileOffset, machoFileSize);
                 const valid = await machoFile.isValid();