Skip to content

add color to selected date on daySelectionAnimation for background inversion #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

add color to selected date on daySelectionAnimation for background inversion #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion example/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ export default class App extends Component<{}> {
<CalendarStrip
scrollable
calendarAnimation={{type: 'sequence', duration: 30}}
daySelectionAnimation={{type: 'background', duration: 300, highlightColor: '#9265DC'}}
daySelectionAnimation={{type: 'background', duration: 300, highlightColor: '#9265DC', color: '#fff'}}
style={{height:200, paddingTop: 20, paddingBottom: 10}}
calendarHeaderStyle={{color: 'white'}}
calendarColor={'#3343CE'}
Expand Down
2 changes: 2 additions & 0 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ interface IDaySelectionAnimationBorder {
animUpdateType?: any;
animProperty?: any;
animSpringDamping?: any;

}

interface IDaySelectionAnimationBackground {
Expand All @@ -27,6 +28,7 @@ interface IDaySelectionAnimationBackground {
animUpdateType: any;
animProperty: any;
animSpringDamping: any;
color: 'string';
Copy link
Collaborator

@peacechen peacechen Dec 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to double quotes for consistency

}

interface IDayComponentProps {
Expand Down
3 changes: 2 additions & 1 deletion src/CalendarDay.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ class CalendarDay extends Component {
borderWidth: 1,
borderHighlightColor: "black",
highlightColor: "yellow",
color: '#fff',
Copy link
Collaborator

@peacechen peacechen Dec 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to double quotes for consistency

animType: LayoutAnimation.Types.easeInEaseOut,
animUpdateType: LayoutAnimation.Types.easeInEaseOut,
animProperty: LayoutAnimation.Properties.opacity,
Expand Down Expand Up @@ -399,7 +400,7 @@ class CalendarDay extends Component {
//If it is border, the user has to input color for border animation
switch (daySelectionAnimation.type) {
case "background":
_dateViewStyle.push({ backgroundColor: daySelectionAnimation.highlightColor });
_dateViewStyle.push({ backgroundColor: daySelectionAnimation.highlightColor, color: daySelectionAnimation.color });
break;
case "border":
_dateViewStyle.push({
Expand Down