Client always times out

[alwhiting]

Perhaps I'm missing something here; but the block starting at this line seems to be causing the client to constantly be reconnecting:

node-hl7-client/src/client/connection.ts

Line 323 in dcc0f10

if (this._main._opt.connectionTimeout > 0 && (this._readyState === ReadyState.CONNECTED || this._readyState === ReadyState.CONNECTING)) {

Is there something that should be done to prevent this behavior? It's not possible to set the connectionTimeout to 0 so this is basically constantly triggering a socket destruction and then the retry logic kicks in. Also the error comes up as "server disconnected" but in reality it is us, the client, who disconnected, which makes me think maybe this is unintentional.

[Bugs5382]

@alwhiting Just so you know I been expecting this myself recently. You might have nailed it. Let me work on it this weekend.

[Bugs5382]

🎉 This issue has been resolved in version 3.0.0-beta.1 🎉

The release is available on:

• npm package (@develop dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[Bugs5382]

@alwhiting I just pushed the changed into the develop branch. There should be a NPM that you should test out prior to me releasing it. I have to do some other internal testing, a lot of other series of tests that I run through not on any CI since this deals with medical applications. So let me know how your testing. By Monday, I will release on main.

[alwhiting]

I have been working around it with this hack for now:

class ClientBugWorkaround extends Client {
    constructor(opts: ClientOptions) {
        const copy = JSON.parse(JSON.stringify(opts));
        copy.connectionTimeout = 1000;
        super(copy);
        this._opt.connectionTimeout = opts.connectionTimeout || 0;
    }
}

That got around the normalize function enforcing a timeout; when it's set to 0 the timeout that was killing the socket was not run.

[Bugs5382]

What’s the PR for this intergrated into the code?

[Bugs5382]

@alwhiting Add it to PR #176 please :)

[alwhiting]

@alwhiting Add it to PR #176 please :)

I didn't actually fork this one just did the hack I pasted above in my code so I could bypass the minimum value for the connectionTimeout option. In the short term I think you could allow that to be set to 0 instead of a minimum of 1000ms. In the longer term I think investigating why that interval exists that calls socket.destroy() is even there... maybe there is a reason for it but I'm not sure what.

[Bugs5382]

sweet. I have already done that in develop:

node-hl7-client/src/utils/normalizedClient.ts

Line 17 in e66b85a

connectionTimeout: 0,

node-hl7-client/src/utils/normalizedClient.ts

Line 163 in e66b85a

assertNumber(props, 'connectionTimeout', 0, 60000)

and now its working like designed. codec is fixed in the node-hl7-package. merging in.