Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: client connection #175

Merged
merged 1 commit into from
Oct 31, 2024
Merged

feat: client connection #175

merged 1 commit into from
Oct 31, 2024

Conversation

Bugs5382
Copy link
Owner

  • default 0 second idle time keeps the connection open
  • disables connection timeout logic if set to 0 (stay connected)
  • updated unit test to reflect that

BREAKING CHANGE: Default now set to be always connected. Must set connectionTimeout, if you want your client to disconnect after a certain time. The max is still 60 seconds.

Closes #169

Search terms

connection timeout

Questioner

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Other things:

  • Write a unit test or update unit tests that cover your change in the code?
  • Set the PR to merge into the develop branch?
  • Clear documentation per the guidelines in the README.md as we are support medical applications?

* default 0 second idle time keeps the connection open
* disables connection timeout logic if set to 0 (stay connected)
* updated unit test to reflect that

BREAKING CHANGE: Default now set to be always connected. Must set connectionTimeout, if you want your client to disconnect after a certain time. The max is still 60 seconds.

Closes #169
@Bugs5382 Bugs5382 added bug Something isn't working enhancement New feature or request labels Oct 31, 2024
@Bugs5382 Bugs5382 self-assigned this Oct 31, 2024
@Bugs5382 Bugs5382 merged commit aeb4108 into develop Oct 31, 2024
3 checks passed
Bugs5382 pushed a commit that referenced this pull request Oct 31, 2024
# [3.0.0-beta.1](v2.3.1...v3.0.0-beta.1) (2024-10-31)

### Features

* client connection ([e6ee6a3](e6ee6a3)), closes [#169](#169)
* client connection ([#175](#175)) ([aeb4108](aeb4108))

### BREAKING CHANGES

* Default now set to be always connected. Must set connectionTimeout, if you want your client to disconnect after a certain time. The max is still 60 seconds.
@Bugs5382
Copy link
Owner Author

🎉 This PR is included in version 3.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Bugs5382 Bugs5382 deleted the 169-client-always-times-out branch October 31, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request released on @develop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant