Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add psychemist builder profile page #39

Merged
merged 9 commits into from
Jan 26, 2025
Merged

Conversation

psychemist
Copy link
Contributor

@psychemist psychemist commented Jan 19, 2025

Description

Implemented a personal builders page with a retro, game-inspired theme and a simple UI that hides cool easter eggs. Includes interaction with GitHub API to fetch image data.

Changes

  • Added page.tsx that exports my personal builder page component
  • Added page.css file that includes styles for specific HTMX elements
  • Added resources.ts file that contains seed arrays for implementing UI designs

Proof

Screenshot 2025-01-19 at 13 59 48

Additional Information

Your ENS/address:
0x8b3C2CB21b6Cb04AE412e41565A804F0bC6D2244

Copy link

vercel bot commented Jan 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
batch12.buidlguidl.com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2025 7:53pm

@psychemist
Copy link
Contributor Author

ready for review @derrekcoleman

Copy link
Collaborator

@phipsae phipsae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really appreciate the effort you put into your profile page!
Well done and so cool, even that you implemented a game, I couldn't figure out how to win xD

Below you'll find some comments, let me know if something is unclear.

@psychemist
Copy link
Contributor Author

@phipsae thanks for your comments! i will implement your suggestions and update my PR.

@psychemist
Copy link
Contributor Author

psychemist commented Jan 21, 2025

Description

Updated builder profile page with corrections suggested by reviewer @phipsae

Changes

  • Changed text font color where applicable to enhance readability in dark and light modes.
  • Enforced typing and naming convention for builder page component.
  • Updated image component from HTML img element to Next Image component for better loading.
  • Moved social media links array outside the main page compoenent.
  • Separated mini game component into a new file for improved structure.
  • Added instructions on how to find and play mini game for better accessibility.

Proof

Screenshot 2025-01-21 at 20 50 09

Additional Information

Related Issues

Closes #11

Your ENS/address:
0x8b3C2CB21b6Cb04AE412e41565A804F0bC6D2244

@psychemist
Copy link
Contributor Author

Ready for review. Please check and merge. @phipsae

Copy link
Collaborator

@phipsae phipsae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the changes!

Just a tiny comment below and then we can merge.

@psychemist

This comment was marked as outdated.

@psychemist
Copy link
Contributor Author

ready for review @phipsae

@psychemist
Copy link
Contributor Author

Description

Added new UI changes for a more polished, retro gaming look

Changes

  • Added custom font for better readability and style conformity.
  • Added background image to enchance user interface.
  • Removed animations (moving line and pulsing dots) and accompanying CSS file.

Proof

Screenshot 2025-01-25 at 20 44 41

Additional Information

Related Issues

Closes #11

Your ENS/address:
0x8b3C2CB21b6Cb04AE412e41565A804F0bC6D2244

@phipsae phipsae merged commit b5b0967 into BuidlGuidl:main Jan 26, 2025
3 checks passed
@phipsae
Copy link
Collaborator

phipsae commented Jan 26, 2025

Thanks so much for your effort! Really nice page! It's merged.

@psychemist
Copy link
Contributor Author

thank you for all your suggestions! @phipsae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants