-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add psychemist builder profile page #39
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ready for review @derrekcoleman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really appreciate the effort you put into your profile page!
Well done and so cool, even that you implemented a game, I couldn't figure out how to win xD
Below you'll find some comments, let me know if something is unclear.
packages/nextjs/app/builders/0x8b3C2CB21b6Cb04AE412e41565A804F0bC6D2244/page.tsx
Show resolved
Hide resolved
packages/nextjs/app/builders/0x8b3C2CB21b6Cb04AE412e41565A804F0bC6D2244/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x8b3C2CB21b6Cb04AE412e41565A804F0bC6D2244/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x8b3C2CB21b6Cb04AE412e41565A804F0bC6D2244/page.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/app/builders/0x8b3C2CB21b6Cb04AE412e41565A804F0bC6D2244/page.tsx
Show resolved
Hide resolved
packages/nextjs/app/builders/0x8b3C2CB21b6Cb04AE412e41565A804F0bC6D2244/page.tsx
Outdated
Show resolved
Hide resolved
@phipsae thanks for your comments! i will implement your suggestions and update my PR. |
DescriptionUpdated builder profile page with corrections suggested by reviewer @phipsae Changes
Proof![]() Additional Information
Related IssuesCloses #11 Your ENS/address: |
Ready for review. Please check and merge. @phipsae |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the changes!
Just a tiny comment below and then we can merge.
packages/nextjs/app/builders/0x8b3C2CB21b6Cb04AE412e41565A804F0bC6D2244/page.tsx
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
ready for review @phipsae |
DescriptionAdded new UI changes for a more polished, retro gaming look Changes
Proof![]() Additional Information
Related IssuesCloses #11 Your ENS/address: |
Thanks so much for your effort! Really nice page! It's merged. |
thank you for all your suggestions! @phipsae |
Description
Implemented a personal builders page with a retro, game-inspired theme and a simple UI that hides cool easter eggs. Includes interaction with GitHub API to fetch image data.
Changes
Proof
Additional Information
Your ENS/address:
0x8b3C2CB21b6Cb04AE412e41565A804F0bC6D2244