-
Notifications
You must be signed in to change notification settings - Fork 1.1k
EDU-134: Add Product editorial code of Blueprints to snippets - All frameworks #3993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDU-134: Add Product editorial code of Blueprints to snippets - All frameworks #3993
Conversation
|
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
9071768 | Triggered | Generic High Entropy Secret | c1ad81a | packages/sdks/e2e/angular-17/src/app/catch-all.component.ts | View secret |
11707119 | Triggered | Generic High Entropy Secret | 21f0136 | packages/sdks/snippets/react-sdk-next-14-app/app/(blueprints-product-details)/products/[handle]/page.tsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
View your CI Pipeline Execution ↗ for commit 3988157.
☁️ Nx Cloud last updated this comment at |
ddb2abb
to
b8601b1
Compare
…prints-prod-editorial-all
- Confirmed Hydrogen tests pass without mocking (7.9s) - Confirmed Vue tests pass with real API calls (6.1s) - Confirmed Svelte tests pass with real API calls (6.1s) - Confirmed React tests pass with real API calls (6.2s) Key insight: Building projects first with 'yarn build' before running 'vite preview' via Playwright resolves API connectivity issues. No mocking required - all frameworks work with real fakestoreapi.com calls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@yash-builder thank you so much for jumping in and figuring out the weird test failures! |
Description
This PR belongs to ticket EDU-134 and is similar to the previously raised React PR on the Product details—blueprints ticket 591. But this PR is more about adding all the frameworks as suggested by Sami to maintain one PR for one framework and use the first PR to work on all review comments and the second PR(like this one) to include all the remaining frameworks.
Frameworks included:
Docs: https://www.builder.io/c/blueprints/product-page-editorial
@sidmohanty11 Please review