Skip to content

EDU-134: Add Product editorial code of Blueprints to snippets - All frameworks #3993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Jun 26, 2025

Conversation

uttej-vsk
Copy link
Contributor

@uttej-vsk uttej-vsk commented Mar 27, 2025

Description

This PR belongs to ticket EDU-134 and is similar to the previously raised React PR on the Product details—blueprints ticket 591. But this PR is more about adding all the frameworks as suggested by Sami to maintain one PR for one framework and use the first PR to work on all review comments and the second PR(like this one) to include all the remaining frameworks.

  • Included all the gen 2 frameworks
  • All test cases are passed
  • Removed unwanted imports and styles
  • Reviewed locally before raising PR

Frameworks included:

  • Vue and its test cases passed
  • Nuxt and its test cases passed
  • Svelte
  • Sveltekit
  • Qwik
  • Hydrogen
  • React SDK Next 14 App
  • React SDK Next pages

Docs: https://www.builder.io/c/blueprints/product-page-editorial

@sidmohanty11 Please review

Copy link

changeset-bot bot commented Mar 27, 2025

⚠️ No Changeset found

Latest commit: 3988157

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

gitguardian bot commented Mar 27, 2025

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9071768 Triggered Generic High Entropy Secret c1ad81a packages/sdks/e2e/angular-17/src/app/catch-all.component.ts View secret
11707119 Triggered Generic High Entropy Secret 21f0136 packages/sdks/snippets/react-sdk-next-14-app/app/(blueprints-product-details)/products/[handle]/page.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

nx-cloud bot commented Mar 27, 2025

View your CI Pipeline Execution ↗ for commit 3988157.

Command Status Duration Result
nx test @e2e/nuxt ✅ Succeeded 7m 52s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-26 04:56:57 UTC

@uttej-vsk uttej-vsk changed the title EDU-134: Add Product editorial code of Blueprints to snippets - All frameworks WIO - EDU-134: Add Product editorial code of Blueprints to snippets - All frameworks Apr 1, 2025
@uttej-vsk uttej-vsk changed the title WIO - EDU-134: Add Product editorial code of Blueprints to snippets - All frameworks [WIP] - EDU-134: Add Product editorial code of Blueprints to snippets - All frameworks Apr 1, 2025
@uttej-vsk uttej-vsk requested a review from sidmohanty11 April 3, 2025 02:36
@uttej-vsk uttej-vsk changed the title [WIP] - EDU-134: Add Product editorial code of Blueprints to snippets - All frameworks EDU-134: Add Product editorial code of Blueprints to snippets - All frameworks Apr 3, 2025
@uttej-vsk uttej-vsk marked this pull request as ready for review April 9, 2025 14:59
@uttej-vsk uttej-vsk enabled auto-merge (squash) June 24, 2025 07:26
@uttej-vsk uttej-vsk disabled auto-merge June 24, 2025 07:26
@uttej-vsk uttej-vsk force-pushed the blueprints-prod-editorial-all branch from ddb2abb to b8601b1 Compare June 24, 2025 21:27
uttej-vsk and others added 7 commits June 24, 2025 16:28
- Confirmed Hydrogen tests pass without mocking (7.9s)
- Confirmed Vue tests pass with real API calls (6.1s)
- Confirmed Svelte tests pass with real API calls (6.1s)
- Confirmed React tests pass with real API calls (6.2s)

Key insight: Building projects first with 'yarn build' before running
'vite preview' via Playwright resolves API connectivity issues.
No mocking required - all frameworks work with real fakestoreapi.com calls.
Copy link
Contributor

@yash-builder yash-builder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uttej-vsk uttej-vsk merged commit 23c0a4b into BuilderIO:main Jun 26, 2025
92 of 93 checks passed
@uttej-vsk uttej-vsk deleted the blueprints-prod-editorial-all branch June 26, 2025 04:57
@uttej-vsk uttej-vsk restored the blueprints-prod-editorial-all branch June 26, 2025 04:58
@sidmohanty11
Copy link
Contributor

sidmohanty11 commented Jun 26, 2025

@yash-builder thank you so much for jumping in and figuring out the weird test failures!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants