Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autogen.sh for new developers #742

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drwilco
Copy link

@drwilco drwilco commented Feb 27, 2016

For convenience, let's have all the autotools in a script.

@ArchangeGabriel
Copy link
Member

I’m not an autotools expert (or even user in fact), the scripts are not from me. What is this supposed to do exactly? Replace this part of the process:
“If you are building from git, you first need to run autoreconf -fi to generate the configure script.”
?

If so, could you:

  1. Explain the benefits (in the expanded commit message if possible);
  2. Update your pull request to modify the README too;
  3. Push it against the develop branch, not the master one.

Thanks!

@ArchangeGabriel
Copy link
Member

Maybe @bluca could answer that too?

@bluca
Copy link
Member

bluca commented May 11, 2016

AFAIK it's very common practice to provide an autogen.sh when using autotools, as the one-stop-shop to initialise the build system. As you guessed, it basically replaces doing autoreconf -f -i, and it has the added benefit that if you need something else done, you just add it to the script and it's transparent for users.
For packagers it doesn't really matter, as in Debian and derivatives there's debhelpers to automate it (dh_autoreconf), but it's handy when doing native builds from upstream sources.

@ArchangeGabriel
Copy link
Member

OK, nice to know. @drwilco Could you just rebase this against develop branch so that I can merge it?

@Lekensteyn
Copy link
Member

Lekensteyn commented May 11, 2016

It is doing the equivalent of autoreconf -fi which is also mentioned in the README. I am not sure if it is that useful (other opinions?)

@bluca
Copy link
Member

bluca commented May 13, 2016

👍 from me, personally I expect autotools-based projects to provide an autogen script
@drwilco - perhaps update the README too?

@ArchangeGabriel
Copy link
Member

OK, I agree to merge this if the README is updated and the PR made against the develop branch.

@drwilco
Copy link
Author

drwilco commented May 25, 2016

I totally missed the autoreconf line in the README. Hah.

I can make the autogen.sh just call that.

@ArchangeGabriel
Copy link
Member

OK. So, please make a new PR against develop branch, add either autoreconf -fi or this PR content into the new autogen.sh file, and update the README for this. ;)

@ArchangeGabriel
Copy link
Member

@drwilco If you don’t do it yourself by next saturday, I’ll end up doing it myself (crediting you in the commit message).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants