config wildcard handling script #901
Conversation
…st hardware supports it
|
Could you please make this optional behind a --configure flag? It's a workaround for a broken distro, so it should not be the default |
|
How should this config flag work? Should it take action at build time? Should this be a flag oft bumblebee.bash at run time? |
|
A build time flag to control what is written in the systemd service file would be enough. This way the ExecStart will be generated to call that bash script only if the flag is true. |
There was a problem hiding this comment.
What distro was this needed for? In the past we had a similar hack for Ubuntu packages:
https://github.com/Bumblebee-Project/bumblebee-ppa/blob/master/xenial/bumblebee/debian/bumblebee.bumblebeed.upstart
| @@ -101,6 +101,17 @@ AS_IF([test "x$with_pidfile" != xno], | |||
| ]) | |||
| AM_CONDITIONAL([WITH_PIDFILE], [test "x$with_pidfile" != xno]) | |||
|
|
|||
|
|
|||
| AC_ARG_ENABLE([wild], | |||
| [ --enable-wild Turn on wildcard support], | |||
There was a problem hiding this comment.
A "wild" daemon is probably not a good idea ;)
Maybe the option and description could be changed to more accurately reflect its functionality?
| ./configure CONF_DRIVER=nvidia CONF_DRIVER_MODULE_NVIDIA=nvidia-375 \ | ||
| CONF_PRIMUS_LD_PATH=/usr/lib/x86_64-linux-gnu/primus:/usr/lib/i386-linux-gnu/primus \ | ||
| CONF_LDPATH_NVIDIA=/usr/lib/nvidia-375:/usr/lib32/nvidia-375 \ | ||
| CONF_MODPATH_NVIDIA=/usr/lib/nvidia-375/xorg,/usr/lib/xorg/modules \ |
There was a problem hiding this comment.
This is prone to getting outdated. Remove it? Instructions in the README should be clear
|
|
||
| ConfDriver=$( crudini --get $ConfFile bumblebeed driver ) | ||
| ConfKernelDriver=$( crudini --get $ConfFile driver-nvidia kerneldriver ) | ||
| ConfLibraryPath=$( crudini --get $ConfFile driver-nvidia librarypath ) |
There was a problem hiding this comment.
crudini is not installed by default.
|
I have forgotten about the earlier PR (#889), but it looks like this does not properly handle multiple installed versions. The glob pattern simply adds all matches. What about this simpler alternative that does not other dependencies: |
The recommended approach handling wildcards in config file with bash script, done for systemd.