Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a link to tmikus/ahocorasick_rs to the README.md - a Go wrapper for this library. #127

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Add a link to tmikus/ahocorasick_rs to the README.md - a Go wrapper for this library. #127

merged 1 commit into from
Aug 30, 2023

Conversation

tmikus
Copy link
Contributor

@tmikus tmikus commented Aug 29, 2023

This commit addresses #125

Are you fine with this kind of section, or should I rename it to something else?

BurntSushi
BurntSushi requested changes Aug 30, 2023
View reviewed changes
Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, whoops, I forgot. There is already a section. This should go in as a new item in the FFI bindings section above it.

Also, you can drop the second sentence. I don't think we need to say that it uses cgo here.

@tmikus
Copy link
Contributor Author

tmikus commented Aug 30, 2023

Done :)

BurntSushi
BurntSushi approved these changes Aug 30, 2023
View reviewed changes
Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BurntSushi BurntSushi merged commit 8659322 into BurntSushi:master Aug 30, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurntSushi BurntSushi BurntSushi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmikus @BurntSushi