Hint to the compiler that returned indices are in-bounds #196
+11
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #195
With this change, this function in a downstream crate:
Generates this assembly:
Assembly output
Whereas before, it would include a branch to
core::slice::index::slice_index_fail.This only works for the oneshot functions, not
memchr_iter, sinceIterdoesn't hold a reference to the original slice. To get the same effect there, I think you'd have to add aoriginal_len: usizefield toIter, which isn't that crazy but maybe seems silly to only use it for an optimization hint.