fix: use -- separator when passing file paths to decompression tools#3282
Open
luinbytes wants to merge 1 commit intoBurntSushi:masterfrom
Open
fix: use -- separator when passing file paths to decompression tools#3282luinbytes wants to merge 1 commit intoBurntSushi:masterfrom
luinbytes wants to merge 1 commit intoBurntSushi:masterfrom
Conversation
When searching compressed files with -z flag, ripgrep calls external
decompression tools (gzip, bzip2, xz, etc.) with the file path as an
argument. Files whose names start with a dash (e.g., '-10.txt.gz') were
being interpreted as command-line options by these tools, causing
errors like:
gzip: invalid option -- '0'
This fix adds a '--' separator before the file path, which signals to
the decompression tools that subsequent arguments are filenames, not
options.
Fixes BurntSushi#3222
Author
|
Hi! Friendly bump on this. Happy to make changes if anything needs adjusting. No rush, just checking it hasn't been missed. Thanks! |
|
Prior art: #3224 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3222 - Files with dash-prefixed names (e.g.,
-10.txt.gz) were causing decompression tools to fail with errors likegzip: invalid option -- '0'when using the-zflag.The Problem
When searching compressed files with
-z, ripgrep spawns external decompression tools (gzip, bzip2, xz, etc.) and passes the file path as an argument:This fails because gzip interprets
-10.txt.gzas options, not a filename.The Fix
Added
--separator before the file path to signal end of options:Testing
Verified locally:
Changes
crates/cli/src/decompress.rs: Single line change to add--separatorThis is a minimal, safe fix that follows standard POSIX conventions for handling dash-prefixed filenames.