feat: add c99 mode in build.rs for issue #33 #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BurntSushi Hi there. PTAL |
BurntSushi
requested changes
Jul 27, 2023
carenas
reviewed
Sep 27, 2023
| // only occurs in some environments, but one possible guess is that this | ||
| // supports older compilers. Either way, there is still some uncertainty | ||
| // about why enabling this flag is necessary. See #33 for more details. | ||
| builder.flag("-std=c99"); |
There was a problem hiding this comment.
gcc < 5 defaults to C89, so it will fail to build as described in PCRE2Project/pcre2#163
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #33. add c99 mode in build.rs for issue #33 for lower cc version.