-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with window pixmaps that have an empty alpha but a valid mask #48
base: master
Are you sure you want to change the base?
Conversation
Hi @BurntSushi. Sorry for asking, but do you have any update on reviewing this? |
Can we bump this one more time? |
I suppose we ought to do so if we don't receive an answer. We could maintain the project with Go module support and fix issues along the way like we did with systray. |
Hi folks. I'm maintaining the |
We can't use GPLv3 in our project. It has all kinds of copyleft implications that can't be used with our BSD Type 2 license |
Ahh, the license. I changed it only to meet the requirements in pkg.go.dev. I was kind of indecisive and picked some that works. I'm sorry if I caused wrong. I can revert the license change and change it to anything more suitable, but you need to help me pick the right license. It has to meet the pkg.go.dev requirements and be as free as possible. |
What you picked was one of the least open. Why not go with the same as Go or other major libraries in the project? Of course going to WTF license to something is easy - to go back to another OSS license you will need to check with every contributor since your fork was created. |
So you say the BSD-3-Clause license is OK? There was no contribution since my license change. It was the last commit. Any contribution happened since my fork, was made under the WTF license. Do I need to check with every contributor since my fork anyway? If I force push with my last commit(s) deleted, it would be like the license change did never happen. Am I wrong? |
Also, I have an issue with the line "Copyright (c) Year, Full name", in the "BSD 3-Clause License". I don't want to have my name or nick in the license. That's one of reasons why I picked the GPLv3. Do you have any suggestions? |
I was too proactive and changed the license (but omitted my name). It is a BSD 3-Clause now. |
When pinging folks, it would be sensible to look at the activity of the project first. I haven't pushed a commit to this project in over 4 years. I don't see that changing any time soon. I do still actually use this repository via my window manager, Wingo. The only changes I'll likely make are ones necessary for it to continue working for myself. |
I agree that forking this into a new project and maintaining it there is a good idea. Making it copyleft seems bananas to me though. And certainly, one shouldn't be choosing a license based on where you put your name. That's a copyright thing, not a license thing. Changing the license to appease Google's overly conservative lawyers is sensible. MIT or BSD seems fine for that purpose. It's not something I'm going to do, but others are welcome to. |
To be fair, the fact that there was no recent activity was the whole reason for the ping in the first place. I was trying to see if there was any hope of new activity. If it was actively maintained I probably wouldn't have needed to ping you. Anyway, thanks for reaching out :) |
Thanks so much for replying @BurntSushi and sorry for pinging you on this. I really appreciate all the work you put into this :). |
We were finding empty images when the icon graphic used the mask to hold all alpha information. This can be tested with the window icon for XTerm.