Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Region RemovePeer function implementation (#126) #158

Merged
merged 2 commits into from
Jul 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion cluster/region/region.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,15 @@ func (r *region) AddPeer(peer string) error {
}

func (r *region) RemovePeer(peer string) error {
panic("implement me")
r.mu.RLock()
defer r.mu.RUnlock()
for i := 0; i < len(r.peers); i++ {
if r.peers[i] == peer {
r.peers = append(r.peers[:i], r.peers[i+1:]...)
return r.raft.DemoteVoter(raft.ServerID(peer), 0, 0).Error()
}
}
return errors.New("the specified peer does not exist")
}

func (r *region) GetSize() int64 {
Expand Down
29 changes: 29 additions & 0 deletions cluster/region/region_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,35 @@ func TestRegion_GetSize(t *testing.T) {
assert.Equal(t, int64(100), size)
}

func TestRegion_RemovePeer(t *testing.T) {
// Create a test region instance
region := NewTestRegion()
_ = []struct {
name string
peers []string
peerToAdd string
expectedPeers []string
expectError bool
}{
{
name: "remove a peer",
peers: region.GetPeers(),
peerToAdd: "peer2",
expectedPeers: []string{"peer1"},
expectError: false,
},
{
name: "remove a non existing peer",
peers: region.GetPeers(),
peerToAdd: "peer3",
expectedPeers: []string{"peer1", "peer2"},
expectError: true,
},
}
destroyRegion(region)

}

func TestRegion_AddPeer(t *testing.T) {
// Create a test region instance
region := NewTestRegion()
Expand Down