muphys: remove scan masks (error now at 1e-7 absolute) #1011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…merge' into muphys_bug_fix
Clean up the graupel_only driver, and create an integration test to run through pytest. Co-authored-by: Will Sawyer <wsawyer@cscs.ch>
Co-authored-by: Will Sawyer <vectorflux@gmail.com> Co-authored-by: Will Sawyer <wsawyer@cscs.ch>
Co-authored-by: Edoardo Paone <edoardo.paone@cscs.ch>
`dz` was computed in the precision of the input file, therefore graupel did not verify to f64 precision for f32 input files.
... and enable it for the graupel_only test and driver.
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run tests with MPI you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
edopao
force-pushed
the
muphys_bug_fix_staging
branch
from
90d9df9 to
fa8e31c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just for comparing performance with other implementations and better understanding of the performance profile.