[WIP] Add tracer advection to standalone driver [cycle 34] #1039
Conversation
nfarabullini
left a comment
nfarabullini
left a comment
There was a problem hiding this comment.
overall you're on the right track
| least_squares_state=advection_states.AdvectionLeastSquaresState( | ||
| # TODO(ricoh): [c34] initialize with zero, check if works | ||
| lsq_pseudoinv_1=data_alloc.constant_field( | ||
| grid, 0.0, dims.CellDim, dims.C2E2CDim, allocator=backend | ||
| ), | ||
| lsq_pseudoinv_2=data_alloc.constant_field( | ||
| grid, 0.0, dims.CellDim, dims.C2E2CDim, allocator=backend | ||
| ), | ||
| ), |
There was a problem hiding this comment.
this part will be different after my PR #1028 is merged
model/standalone_driver/src/icon4py/model/standalone_driver/driver_utils.py
Show resolved
Hide resolved
| ) | ||
|
|
||
| return diffusion_granule, solve_nonhydro_granule | ||
| advection_granule = advection.convert_config_to_advection( |
There was a problem hiding this comment.
opinion: I'd call it tracer_advection_granule to explicitly distinguish from velocity_advection
There was a problem hiding this comment.
general comment for the PR:
_mc in ICONf90 stands for "model" (i.e. KDim = nlev) "cell"
ifc stands for "interface" (i.e. KHalfDim = nlev + 1) "cell"
we should keep these suffixes only in metrics_attributes.py icon_var_name like you did already, and get rid of them everywhere else in icon4py (then you are also consistent with the name you gave them in metrics_attributes.py)
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:
For more detailed information please look at CI in the EXCLAIM universe. |
|
cscs-ci run default |
3 participants
This is not for merging, I am asking for comments on the approach, because I am still learning about this part of the code.