Skip to content

Conversation

@jcanton
Copy link
Contributor

@jcanton jcanton commented Feb 11, 2026

When naively translating a Fortran list to a full field, we constructed a mask instead of using the fact that we are actually initializing a weight with 0.0 in the masked-out cases.

Additionally: Remove program and a trivial test.

same as #1053 but for mask_hdiff

@jcanton jcanton changed the title cleanup Replace mask_hdiff by multiplying with 0.0 Feb 11, 2026
@jcanton jcanton changed the title Replace mask_hdiff by multiplying with 0.0 Replace mask_hdiff by multiplying with 0.0 Feb 11, 2026
@jcanton jcanton requested review from havogt and muellch February 11, 2026 15:43
@jcanton jcanton changed the title Replace mask_hdiff by multiplying with 0.0 Replace mask_hdiff by multiplying with 0.0 Feb 11, 2026
@jcanton
Copy link
Contributor Author

jcanton commented Feb 11, 2026

cscs-ci run default

@jcanton
Copy link
Contributor Author

jcanton commented Feb 11, 2026

cscs-ci run distributed

@github-actions
Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • cscs-ci run distributed

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark-bencher

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

To run test levels ignored by the default test suite (mostly simple datatest for static fields computations) you can use:

  • cscs-ci run extra

For more detailed information please look at CI in the EXCLAIM universe.

@muellch
Copy link
Contributor

muellch commented Feb 11, 2026

@havogt This one is even better for a performance comparison.

  • The frequency the mask is true is very very small
  • The combined stencil around this one is way smaller, so differences are easier to see.

Copy link
Contributor

@muellch muellch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same problem as before, makes code cleaner but might degrade performance.
This one should be a more obvious example since the mask is true only for few points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants