Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/solve circular import problem #2309

Closed
wants to merge 2 commits into from
Closed

Feature/solve circular import problem #2309

wants to merge 2 commits into from

Conversation

jing12345678910
Copy link
Contributor

@jing12345678910 jing12345678910 commented Sep 6, 2024 •
edited
Loading

DEVELOP

檢查的時候發現有問題，請先不要核

  • solve circular import problem
  • 有關循環引用的問題：
    • 譬如我在全域搜尋ConfirmModal，只有src/components/confirm_modal/confirm_modal.tsx 和src/contexts/global_context.tsx 兩個檔案使用到，其他檔案沒有使用，而剛好這兩個檔案發生循環引用，因此我處理的方式是在global_context.tsx 中把ConfirmModal 拿掉，處理完之後就只有confirm_modal.tsx 搜尋得到ConfirmModal
    • image

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 0
  • new loop: 0
  • new recursive: 0
  • high risk: 0
  • new sql: 0

UML

  • None

@jing12345678910 jing12345678910 self-assigned this Sep 6, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
i-sun-fa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 5:37am

@jing12345678910 jing12345678910 marked this pull request as draft September 6, 2024 10:06
@jing12345678910 jing12345678910 deleted the feature/solve_circular_import_problem branch September 9, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Awaiting requested review from Luphia

Assignees

@jing12345678910 jing12345678910

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jing12345678910