Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-2037 Hotfix: Reset page when table view changes #600

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

Alejandro-Vega
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega commented Jan 22, 2025

Overview

Added missing dep so that the table resets the page to 0 once the table view changes within the Validation Results tab in a Data Submission.

Change Details (Specifics)

  • If you switch to a different page, then switch table view, then the page would try to persist. Updated this so that it reset back to 0 when table view changes.

Related Ticket(s)

CRDCDH-2037 (Task)
CRDCDH-1889 (US)

@Alejandro-Vega Alejandro-Vega added this to the 3.2.0 (PMVP-M3) milestone Jan 22, 2025
@amattu2 amattu2 added the Not Run This PR was not tested locally label Jan 22, 2025
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amattu2 amattu2 merged commit 47f7691 into 3.2.0 Jan 22, 2025
5 checks passed
@amattu2 amattu2 deleted the CRDCDH-2037-hotfix branch January 22, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Not Run This PR was not tested locally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants