Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRDCDH-2271 Limit Collaborator editing for specific Submission statuses #603

Merged
merged 1 commit into from
Jan 23, 2025
Merged

CRDCDH-2271 Limit Collaborator editing for specific Submission statuses #603

merged 1 commit into from
Jan 23, 2025

Conversation

Alejandro-Vega
Copy link
Collaborator

Overview

Restrict the Submitter from modifying the Collaborators within the dialog when a submission is in Completed, Canceled, or Deleted status.

Change Details (Specifics)

N/A

Related Ticket(s)

CRDCDH-2271 (Task)
CRDCDH-2035 (US)

@Alejandro-Vega Alejandro-Vega added this to the 3.2.0 (PMVP-M3) milestone Jan 23, 2025
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12933047834

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 57.952%
Totals Coverage Status
Change from base Build 12913595553: 0.007%
Covered Lines: 4029
Relevant Lines: 6517
💛 - Coveralls

@amattu2 amattu2 added the Not Run This PR was not tested locally label Jan 23, 2025
amattu2
amattu2 approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@amattu2 amattu2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I didn't test locally, but given the test coverage, I trust it works 😃

@amattu2 amattu2 merged commit bc7a903 into 3.2.0 Jan 23, 2025
7 checks passed
@amattu2 amattu2 deleted the CRDCDH-2271 branch January 23, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amattu2 amattu2 amattu2 approved these changes

Assignees
No one assigned
Labels
Not Run This PR was not tested locally
Projects
None yet
Milestone
3.2.0 (PMVP-M3)
Development

Successfully merging this pull request may close these issues.
3 participants
@Alejandro-Vega @coveralls @amattu2