Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-2266 Support Viewing Older Data Model Versions #605

Draft
wants to merge 5 commits into
base: 3.2.0
Choose a base branch
from

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Jan 23, 2025

Overview

This PR extends the Model Navigator implementation to support viewing of older Data Model versions, as well as some code QoL changes.

Note

This PR is still waiting for a UX design on the Data Submission dashboard page.
If possible, also Controller coverage?

Change Details (Specifics)

  • Add optional version parameter to Model Navigator URL, if empty, redirect to /{model}/latest
  • Fetch the Data Model assets based on the provided version
  • Add a hyperlink from the Data Submission List page to the Model Navigator Viewer for that Model Version
  • Rename "modelNavigator" content folder to "ModelNavigator"

Related Ticket(s)

CRDCDH-2266 (Task)
CRDCDH-2159 (US)

@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label Jan 23, 2025
@amattu2 amattu2 added this to the 3.2.0 (PMVP-M3) milestone Jan 23, 2025
@amattu2 amattu2 changed the title CRDCDH-2266 Support Viewing History Model Versions in Model Navigator CRDCDH-2266 Support Viewing Older Data Model Versions Jan 23, 2025
@coveralls
Copy link
Collaborator

coveralls commented Jan 23, 2025

Pull Request Test Coverage Report for Build 12936256468

Details

  • 6 of 19 (31.58%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 57.907%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/router.tsx 0 1 0.0%
src/hooks/useBuildReduxStore.ts 0 2 0.0%
src/content/ModelNavigator/Controller.tsx 0 3 0.0%
src/content/ModelNavigator/NavigatorView.tsx 0 3 0.0%
src/content/dataSubmissions/DataSubmissionsListView.tsx 0 4 0.0%
Totals Coverage Status
Change from base Build 12933185675: -0.05%
Covered Lines: 4033
Relevant Lines: 6526

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 Do Not Merge This PR is not ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants