Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDCDH-2265 Support multi-select status selection #606

Merged
merged 5 commits into from
Feb 3, 2025
Merged

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Jan 23, 2025

Overview

This PR allows multi-selection of the Data Submission List > Status Filter.

Note

It's possible to deselect every status, in which case no results are returned.

Change Details (Specifics)

  • Update the Status input to multi-select
  • Update the order of the status option list to match requirements
  • Update the listSubmissions API to use a Typed Document and change the input typing
  • Change searchParams implementation for the status field to an array-based implementation (status=x1&status=x2...)
  • Export the default form values and use that for the Data Submission List formRef instead of duplicating fields
  • Remove very very old MVP-1 note

Related Ticket(s)

CRDCDH-2265 (Task)
CRDCDH-2206 (US)

@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label Jan 23, 2025
@amattu2 amattu2 added this to the 3.2.0 (PMVP-M3) milestone Jan 23, 2025
@coveralls
Copy link
Collaborator

coveralls commented Jan 23, 2025

Pull Request Test Coverage Report for Build 13115827658

Details

  • 13 of 15 (86.67%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 58.177%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/DataSubmissions/DataSubmissionListFilters.tsx 12 13 92.31%
src/content/dataSubmissions/DataSubmissionsListView.tsx 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/DataSubmissions/DataSubmissionListFilters.tsx 2 92.76%
Totals Coverage Status
Change from base Build 13079238301: -0.02%
Covered Lines: 4061
Relevant Lines: 6543

💛 - Coveralls

@amattu2 amattu2 removed the 🚧 Do Not Merge This PR is not ready for merging label Jan 31, 2025
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super small change requested. Everything else LGTM! Well done.

@Alejandro-Vega Alejandro-Vega added the 📝 Change Requested This PR has requested changes label Jan 31, 2025
@amattu2 amattu2 removed the 📝 Change Requested This PR has requested changes label Feb 3, 2025
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit a1b1969 into 3.2.0 Feb 3, 2025
7 checks passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-2265 branch February 3, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants