Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include libraries in package data #27

Merged
merged 6 commits into from
Nov 6, 2023
Merged

fix: include libraries in package data #27

merged 6 commits into from
Nov 6, 2023

Conversation

kelly-sovacool
Copy link
Member

Changes

  • All subdirectories of assets/ are now included as package data.
  • Use file(checkIfExists: true) in nextflow to fail fast when files don't exist.

Issues

Resolves #26

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • [ ] Write unit tests for any new features, bug fixes, or other code changes. testing framework not yet implemented
  • [ ] Update docs if there are any API changes. on hold until before public release
  • [ ] If a new nextflow process is implemented, define the process container and stub.
  • Update CHANGELOG.md with a short description of any user-facing changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

Copy link
Contributor

@slsevilla slsevilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed a test run successfully. Issue has been resolved.

@slsevilla slsevilla merged commit 3ffca54 into main Nov 6, 2023
1 check passed
@slsevilla slsevilla deleted the iss-26 branch November 6, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error finding library file in nf-TRIM_COUNT_MAGECK_COUNT
2 participants