[FIX] Delete empty output files instead of leaving 0-byte files (#1282) #1877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using --output-field both (formerly -12), CCExtractor creates separate output files for each field. If one field has no captions, a 0-byte file was left behind, which is confusing for users. This fix checks the file size in dinit_write() before closing. If the file is empty (0 bytes), it deletes the file and prints an informational message. This is a simpler approach than deferred file creation - files are still created at initialization but cleaned up if they remain empty. Fixes #1282 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit e3b0def...:
Your PR breaks these cases:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
--output-field both, CCExtractor creates separate output files for each fielddinit_write()before closing - if empty, deletes the fileApproach
This is a simpler approach than PR #1793 (deferred file creation):
Test Results
Only the file with actual captions remains.
Fixes #1282
🤖 Generated with Claude Code