Skip to content

Feat(rust): Implement WebVTT-specific timestamp format and layout anchor #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cfsmp3 merged 3 commits into from
Mar 7, 2026
+14 −3
Merged

Feat(rust): Implement WebVTT-specific timestamp format and layout anchor #2135

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0cf623
Feat(rust): Implement WebVTT-specific timestamp format and layout anchor
pranavshar223 Feb 22, 2026
25f0b86
style: apply rustfmt to g608.rs
pranavshar223 Feb 22, 2026
ffe4a4a
fix(rust): use WebVTT-spec dot separator for milliseconds in timestam…
pranavshar223 Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/rust/src/encoder/g608.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,20 @@ pub fn write_cc_buffer_as_g608(data: &eia608_screen, context: &mut encoder_ctx)
}

// Create timeline string for timestamps
let timestamp_line = format!(
"{h1:02}:{m1:02}:{s1:02},{ms1:03} --> {h2:02}:{m2:02}:{s2:02},{ms2:03}{encoded_clrf}"
);
let is_webvtt = context.write_format == crate::bindings::ccx_output_format::CCX_OF_WEBVTT;

let timestamp_line = if is_webvtt {
// WebVTT Standard requires dots instead of commas for milliseconds
// and supports trailing settings (e.g., vertical text direction, alignment)
format!(
"{h1:02}:{m1:02}:{s1:02}.{ms1:03} --> {h2:02}:{m2:02}:{s2:02}.{ms2:03}{encoded_clrf}"
)
} else {
// Legacy SRT Standard requires commas
format!(
"{h1:02}:{m1:02}:{s1:02},{ms1:03} --> {h2:02}:{m2:02}:{s2:02},{ms2:03}{encoded_clrf}"
)
};

// Encode and write timestamp line
let used = encode_line(context, buffer_slice, timestamp_line.as_bytes());
Expand Down
Loading