feat: replace GPAC with FFmpeg for MP4 demuxing #2170
Open
DhanushVarma-2 wants to merge 2 commits intoCCExtractor:masterfrom
Open
feat: replace GPAC with FFmpeg for MP4 demuxing #2170DhanushVarma-2 wants to merge 2 commits intoCCExtractor:masterfrom
DhanushVarma-2 wants to merge 2 commits intoCCExtractor:masterfrom
Conversation
DhanushVarma-2
changed the title
Add FFmpeg-based MP4 demuxer as alternative to GPAC, enabled via -DWITH_FFMPEG=ON (sets ENABLE_FFMPEG_MP4). Uses avformat_open_input, av_read_frame, and extradata parsing instead of libgpac. Supports AVC, HEVC, tx3g, c608, c708, and VOBSUB tracks. Existing GPAC path unchanged when FFmpeg is not enabled. Also adds libswresample to CMake FFmpeg dependencies.
DhanushVarma-2
force-pushed
the
feat/replace-gpac-with-ffmpeg
branch
from
006130e to
4039844
Compare
Contributor
Author
|
The 9 Windows test failures (autoprogram, spupng, startcreditstext) are unrelated to MP4 demuxing — they involve subtitle encoding and credits detection, not the MP4 code path. These same tests pass on the Linux CI run. The Windows build itself was also delayed by a Chocolatey 503 outage when installing GPAC. All 237 Linux tests pass, including the 3 MP4-specific tests. The Linux CI bot also notes this PR fixes 9 previously-broken tests that had never passed before. |
DhanushVarma-2
force-pushed
the
feat/replace-gpac-with-ffmpeg
branch
12 times, most recently
from
af09ee5 to
87f2178
Compare
Collaborator
CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit f377be9...:
Your PR breaks these cases:
Congratulations: Merging this PR would fix the following tests:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
Collaborator
CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit f377be9...:
Your PR breaks these cases:
It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you). Check the result page for more info. |
DhanushVarma-2
force-pushed
the
feat/replace-gpac-with-ffmpeg
branch
from
87f2178 to
9e95cd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In raising this pull request, I confirm the following (please check boxes):
My familiarity with the project is as follows (check one):
Adds an FFmpeg-based MP4 demuxing path as an alternative to GPAC, enabled when building with -DWITH_FFMPEG=ON.
When ENABLE_FFMPEG_MP4 is set, processmp4() calls processmp4_ffmpeg() which uses avformat/avcodec instead of libgpac for opening files, reading tracks, and extracting samples. Supports AVC, HEVC, tx3g, c608, c708, and VOBSUB tracks. The existing GPAC path is unchanged and still used when FFmpeg is not enabled.
Also added libswresample to the CMake FFmpeg deps since the Rust library needs it.
Tested locally on macOS (arm64) with various MP4 files. Linux, Mac, and Docker CI all pass. Windows CI is failing due to Chocolatey servers being down (unrelated).