Skip to content

Commit

Permalink
Merge pull request #60 from knikolla/fix_typeerror
Browse files Browse the repository at this point in the history
Handle TypeError in Pci Requests
  • Loading branch information
knikolla authored May 1, 2024
2 parents cb53f9f + 6ef81e9 commit 916a6af
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion src/openstack_billing_db/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,12 @@
import datetime
from dataclasses import dataclass
from dataclasses_json import dataclass_json
import logging
import sqlite3
from typing import Optional

logger = logging.getLogger(__name__)


@dataclass_json()
@dataclass()
Expand Down Expand Up @@ -230,7 +233,13 @@ def get_instances(self, project) -> list[Instance]:
)

for instance in cursor.fetchall():
pci_info = json.loads(instance["pci_requests"])
try:
pci_info = json.loads(instance["pci_requests"])
except TypeError:
pci_info = None
logger.warning(
f"Could not parse pci requests from instance {instance}."
)
su_name = "cpu"
if pci_info:
# The PCI Requests column of the database contains a JSON
Expand Down

0 comments on commit 916a6af

Please sign in to comment.