Implemented processor for Lenovo processing #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knikolla
reviewed
Oct 17, 2024
QuanMPhm
force-pushed
the
103/proc_lenovo
branch
from
018a36c
to
79cdd0c
Compare
knikolla
requested changes
Oct 22, 2024
QuanMPhm
force-pushed
the
103/proc_lenovo
branch
from
79cdd0c
to
7fe7ef0
Compare
Note that, for now, only the Lenovo invoice will take the processed data from the `LenovoProcessor`. All other invoices will take the data from `AddInstituteProcessor`. This is due to the processors adding new columns. This odd code design will be removed once invoices gain the feature to filter out their exported columns.
QuanMPhm
force-pushed
the
103/proc_lenovo
branch
from
7fe7ef0
to
d0d0d65
Compare
knikolla
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #103. Dependant on #99 and #100. Note that, for now, only the Lenovo invoice will take the processed data from the
LenovoProcessor. All other invoices will take the data fromAddInstituteProcessor. This is due to the processors adding new columns. This odd code design will be removed once invoices gain the feature to filter out their exported columns.