Implemented processing and exporting for BU Internal invoice #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knikolla
reviewed
Apr 24, 2024
QuanMPhm
force-pushed
the
25/BU_internal_subsidy
branch
from
45dd69d
to
d676c4a
Compare
QuanMPhm
force-pushed
the
25/BU_internal_subsidy
branch
2 times, most recently
from
e2716be
to
74bc0f8
Compare
|
@knikolla I'll rebase once I know which PR is approved? |
knikolla
requested changes
Apr 25, 2024
QuanMPhm
force-pushed
the
25/BU_internal_subsidy
branch
from
74bc0f8
to
d8d3234
Compare
naved001
reviewed
Apr 29, 2024
QuanMPhm
force-pushed
the
25/BU_internal_subsidy
branch
from
d8d3234
to
479f87e
Compare
naved001
approved these changes
Apr 29, 2024
QuanMPhm
force-pushed
the
25/BU_internal_subsidy
branch
from
479f87e
to
1fbd44b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25 fully, I have implemented the function to export the BU Internal invoice, following @joachimweyl's specifications in the linked issue.
The BU subsidy will be applied to every BU PI after the New-PI credit is applied to eligible PIs in the combined invoice. With how this is currently implemented, the combined invoice may NOT show BU PIs' final balances, as the BU-only invoice is made and exported after the combined invoice is exported.
The current subsidy is set at $100, but I have made the amount configurable via a cli arguement.