Removed HU invoice processing and added S3 export function for HU-BU invoice #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@QuanMPhm The button to ask for reviews is different from the button to "assign" a PR. |
knikolla
requested review from
knikolla and
naved001
and removed request for
knikolla
knikolla
approved these changes
Apr 25, 2024
naved001
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29, I've removed HU invoice processing, and added an S3 export function to specifically export the HU-BU invoice. Since the HU-BU invoice will now be exported to a (mostly) hardcoded path in S3, the user's choice of filename for the HU-BU invoice will no longer matter when it is exported to S3.