Feedback #1
Open
Feedback #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Built libGDX project structure
Developed initial barebones structure. Very limited functionality.
Added basic code to Path class
CoR pattern, not yet functional
please ignore, not important
Repair attempt
Re-added levels-related class and interface files
I followed a YouTube tutorial series (https://youtube.com/playlist?list=PL_QPQmz5C6WUF-pOQDsbsKbaBZqXj4qSq) which shows how to make a 2D game in Java. The first few videos showed me how to structure this framework, but the video is showing how to make a different type of game, so I had to change many things about the code. The framework I have here includes a Main.java class which starts the game, a GamePanel.java class which renders the game, and the very basics of towers. I have a superclass Entity.java which is intended to be the parent of both Tower.java and eventually Enemy.java when that is merged in. Thus far, I have implemented the singleton pattern on GamePanel.java, as we only want one rendering of the game per instance of the application. I have also implemented the Enum pattern for the types of towers so that we can make balance changes to the game all in one place, and there is no chance of creating a tower with the wrong stats. I also know this should have been broken into smaller commits. I wanted to finish the first few episodes of the tutorial, commit that, and then start making changes, but I didn't want gitHub to keep the files we don't need from the tutorial.
Set up basic framework for project and towers
Updated names on all final fields to be all caps with underscore spacing. Made Entity.java an abstract class with abstract definitions for update() and draw() since all entities must do this.
Added javadoc comments on public or notable methods. Renamed TowerTypes.getSprite() to TowerTypes.getSpriteFilePath() for greater clarity.
Implemented clone method in Enemy.java
Implemented enemy spawning
Added startX, startY, and startDir Added all necessary logic and updated the levels text files
Added get methods in Level base class for startX, startY, and startDir.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mainsince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
mainsince the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.main. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @rbalmeida-git @P-arias @sharpworks-dev