-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Lambda to generate pre-signed URLs for uploading files #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor comments.
LGTM
@@ -0,0 +1,138 @@ | |||
const mockGetExport = jest.fn(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to run these unit tests locally? Whenever I try I get the error "Cannot find module '@aws-sdk/client-cloudformation'".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, you need to be in the lambdas/api/put_dmps_uploads
dir and run npm install
first then npm run test
that should install all of those dev dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did that, but still see that error for some reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. try going into the lambda/layers/dmptool/cloudformation
directory and run npm install
. Then go back to the lambda/api/put_dmps_uploads
dir and run the tests again. They reference those lambda layers directly when you run locally so I wonder if the error is actually coming from the layer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @briri. That worked
New API function to support the generate of pre-signed URLs that COKI can use to send us match data files.
Initial part of #21.
Also fixed up some issues with the API function that pre-signs URLs to download DMP metadata files:
sam_build_deploy.rb
script