Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary 'version' element from docker-compose files #50

Conversation

dmccoystephenson
Copy link
Member

Problem

The 'version' element is obsolete and no longer necessary. See https://github.com/compose-spec/compose-spec/blob/main/spec.md#version-and-name-top-level-elements

When using docker compose, the user receives a warning about this and this can be confusing.

Solution

The 'version' element has been removed from the docker-compose files.

USDOT PR

This addresses a comment on usdot-jpo-ode#41

Copy link

@Michael7371 Michael7371 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@mwodahl mwodahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@dmccoystephenson dmccoystephenson merged commit a4b8f9d into develop Sep 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants