Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mrinufft #166

Closed
wants to merge 7 commits into from
Closed

Mrinufft #166

wants to merge 7 commits into from

Conversation

chaithyagr
Copy link
Contributor

Make pysap-mri compatible with mri-nufft

@chaithyagr chaithyagr requested a review from paquiteau January 8, 2024 15:33
@chaithyagr chaithyagr requested a review from paquiteau January 10, 2024 07:35
@chaithyagr chaithyagr self-assigned this Jan 10, 2024
@chaithyagr chaithyagr marked this pull request as ready for review January 10, 2024 07:35
@chaithyagr
Copy link
Contributor Author

I have refactored all the codes and now it is ready for review @paquiteau

Copy link
Contributor

@paquiteau paquiteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job !
Some remarks:

  • I think the density examples could be merge into one (to ease the comparison between them).
  • You removed the stacked nufft operator, without providing a replacement (there is one in mri-nufft however), maybe we want a dedicated example for that too.

examples/CalibrationlessReconstruction_GL_Cartesian.py Outdated Show resolved Hide resolved
examples/gridsearch_launch.py Show resolved Hide resolved
@chaithyagr
Copy link
Contributor Author

I have now rebased to develop branch to include auto threshold stuff

@chaithyagr
Copy link
Contributor Author

chaithyagr commented Jan 10, 2024

Great job ! Some remarks:

  • I think the density examples could be merge into one (to ease the comparison between them).

While I agree, I kept the CPU and GPU one different fow now to have atleast one on the Gallery. I plan to add cell_count to the SENSE reconstruction stuff . That way we have it all in same place but with a catch that it can be run only on GPU pipeline (self-hosted runner)

  • You removed the stacked nufft operator, without providing a replacement (there is one in mri-nufft however), maybe we want a dedicated example for that too.

At the moment I dont see a need for it sadly... We can add one soon when we get to it I guess?

@chaithyagr chaithyagr closed this Jan 19, 2024
@chaithyagr chaithyagr deleted the mrinufft branch January 19, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants