-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mrinufft #166
Mrinufft #166
Conversation
I have refactored all the codes and now it is ready for review @paquiteau |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job !
Some remarks:
- I think the density examples could be merge into one (to ease the comparison between them).
- You removed the stacked nufft operator, without providing a replacement (there is one in mri-nufft however), maybe we want a dedicated example for that too.
I have now rebased to |
While I agree, I kept the CPU and GPU one different fow now to have atleast one on the Gallery. I plan to add cell_count to the SENSE reconstruction stuff . That way we have it all in same place but with a catch that it can be run only on GPU pipeline (self-hosted runner)
At the moment I dont see a need for it sadly... We can add one soon when we get to it I guess? |
Make pysap-mri compatible with mri-nufft