-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation and Packaging update (Pre mc/dc 0.0.9) #149
Conversation
Please note I am an awful speller while I do have spell check in VS code, someone should really give my copy a once over. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes to mcdc/input_.py are in the docstrings of some functions to fix some sphinx issues.
@jpmorgan98, let's merge it in after we are back in |
Ok we should be good note that it looks like some stuff in the black standard has changed and you might need to update your version to get it to work |
Changes:
Documentation
Paper
I wrote a paper for JOSS submission and added the github workflow to compile it. The runner will be turned off after all updates are in. Please look over and see
Packaging
Packaging is provided through pip. This required a new
.toml
file and some creation of new accounts and API tokens to make it all work the CI runner which will deploy when a new version is detected. I also set up zenodo repo. Please note the new minimum requirements listed in the.toml
file.New build options
Due to the significant size of
netgen
(~300MB) and its dependencies I added visualization as an optional build. This can installed byTo make the dependencies optional I put the
import
s in atry
andexcept
phraseology with a warning message when going to installI also configured it to install the documentation dependencies in the same manner
Github CIs
When
pip install .
is run in a local directory all the necessary dependence will be snagged as part of that operation. So I disabled those in the github runner CIs. I also included 2 new runners to build the paper and package mcdc for pypi.README.md
I made significant changes to the
README.md
file to describe these changesNext steps
After this PR is accepted I will release version
0.9.0
which will provide a final update to pip for the packageI will fix some links to the documentation.
I will submit that paper to JOSS