-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add forti vuln module #105
Conversation
from artemis.reporting.utils import get_top_level_target | ||
|
||
|
||
class FortiVulnReporter(Reporter): # type: ignore[misc] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not too broad ignore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
docker-compose.yml
Outdated
@@ -36,9 +36,22 @@ services: | |||
command: "python3 -m artemis.modules.karton_ssl_checks" | |||
profiles: [not-arm] | |||
|
|||
karton-forti_vuln: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sort kartons alphaetically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now they are sorted
forti_vuln/forti_vuln.py
Outdated
http_host = f"{host}:{port}" | ||
self.log.info(f"forti vuln scanning {http_host}") | ||
|
||
user_agent = "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we send an empty one? or sth generic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added default user agent just in case
forti_vuln/forti_vuln.py
Outdated
status_reason = "Detected CVE-2024-21762 vulnerability" | ||
else: | ||
status = TaskStatus.ERROR | ||
status_reason = "Omitted because service does not use ssl encryption" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why no check if no ssl?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added support for services without ssl
No description provided.