New module using what-vpn #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazet
reviewed
Sep 1, 2024
extra_modules_config.py
Outdated
| # Timeout counted in seconds, after which the what-vpn module terminates a connection and starts using the next sniffer. | ||
| # Some of VPN gateways do not respond in any way to the HTTP(S) requests, so the timeout variable should be optimized in | ||
| # order to avoid false negatives while not blocking the task for too long. | ||
| WHATVPN_TIMEOUT_S = decouple.config( |
There was a problem hiding this comment.
Changed all occurrences
kazet
reviewed
Sep 1, 2024
karton_whatvpn/Dockerfile
Outdated
|
|
||
| RUN apk add git | ||
| RUN pip install requests | ||
| RUN pip3 install https://github.com/dlenski/what-vpn/archive/master.zip |
There was a problem hiding this comment.
pinned latest hash on master branch
kazet
reviewed
Sep 1, 2024
karton_whatvpn/Dockerfile
Outdated
| FROM certpl/artemis:latest | ||
|
|
||
| RUN apk add git | ||
| RUN pip install requests |
There was a problem hiding this comment.
requests is already in the artemis image
kazet
reviewed
Sep 1, 2024
karton_whatvpn/karton_whatvpn.py
Outdated
|
|
||
| identity = "what-vpn" | ||
| filters = [ | ||
| {"type": TaskType.IP.value} |
There was a problem hiding this comment.
hmmm, if you want a service on a port, use TaskType.SERVICE
There was a problem hiding this comment.
I'll stay with IP task type as profit from scanning all discovered ports is debatable while increase number of sent requests is noticeable.
Might change in the future based on observations.
kazet
reviewed
Sep 1, 2024
|
|
||
| error_messages = ["error", "timeout", "no match"] | ||
| if any(msg in output for msg in error_messages): | ||
| status = TaskStatus.OK |
There was a problem hiding this comment.
changed the logic to return separate OK and ERROR statuses
|
fix linter ;) |
kazet
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes use of what-vpn project, enabling Artemis to identify SSL VPN servers.
Takes IPs as input, subject to change (other alternatives are domains or HTTP servises)