Skip to content

Passing tags to karton. #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2024
Merged

Passing tags to karton. #934

merged 2 commits into from
May 16, 2024

Conversation

aBUDmdBQ
Copy link
Contributor

@aBUDmdBQ aBUDmdBQ commented May 6, 2024

Passing tags to karton can be extremly useful in some scenarios.

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current behaviour?
When a Task object is created for karton, currently only attributes and a Resource object are passed.

What is the new behaviour?
In addition tags will now be passed (as strings) to enable conditional processing by karton based on file tags.

Test plan
From within karton modules you should be able to access file tags by task.get_payload("tags").

aBUDmdBQ and others added 2 commits May 6, 2024 09:00
Passing tags to karton can be extremly useful in some scenarios.
@psrok1 psrok1 self-requested a review May 16, 2024 16:17
Copy link
Member

@psrok1 psrok1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@psrok1 psrok1 merged commit aba42f1 into CERT-Polska:master May 16, 2024
@psrok1 psrok1 mentioned this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants