Fix code formatting

process/mqtt.cpp

@@ -1,29 +1,32 @@
 /**
-* \file mqtt.hpp
-* \brief MQTT plugin for ipfixprobe
-* \author Damir Zainullin <zaidamilda@gmail.com>
-* \date 2024
+ * \file mqtt.hpp
+ * \brief MQTT plugin for ipfixprobe
+ * \author Damir Zainullin <zaidamilda@gmail.com>
+ * \date 2024
  */
 /*
-* Copyright (C) 2023 CESNET
-*
-* LICENSE TERMS
-*
-* Redistribution and use in source and binary forms, with or without
-* modification, are permitted provided that the following conditions
-* are met:
-* 1. Redistributions of source code must retain the above copyright
-*    notice, this list of conditions and the following disclaimer.
-* 2. Redistributions in binary form must reproduce the above copyright
-*    notice, this list of conditions and the following disclaimer in
-*    the documentation and/or other materials provided with the
-*    distribution.
-* 3. Neither the name of the Company nor the names of its contributors
-*    may be used to endorse or promote products derived from this
-*    software without specific prior written permission.
+ * Copyright (C) 2023 CESNET
+ *
+ * LICENSE TERMS
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in
+ *    the documentation and/or other materials provided with the
+ *    distribution.
+ * 3. Neither the name of the Company nor the names of its contributors
+ *    may be used to endorse or promote products derived from this
+ *    software without specific prior written permission.
  */
+
 #include "mqtt.hpp"
-#include "cstring"
+
+#include <cstring>
+
 #ifdef DEBUG_MQTT
 static const bool debug_mqtt = true;
 #else
@@ -33,60 +36,67 @@ namespace ipxp {
 
 int RecordExtMQTT::REGISTERED_ID = -1;
 
-__attribute__((constructor)) static void register_this_plugin(){
+__attribute__((constructor)) static void register_this_plugin()
+{
     static PluginRecord rec = PluginRecord("mqtt", []() { return new MQTTPlugin(); });
     register_plugin(&rec);
     RecordExtMQTT::REGISTERED_ID = register_extension();
 }
 
-int MQTTPlugin::post_create(Flow &rec, const Packet &pkt){
+int MQTTPlugin::post_create(Flow& rec, const Packet& pkt)
+{
     if (has_mqtt_protocol_name(reinterpret_cast<const char*>(pkt.payload), pkt.payload_len))
         add_ext_mqtt(reinterpret_cast<const char*>(pkt.payload), pkt.payload_len, rec);
     return 0;
 }
 
-int MQTTPlugin::pre_update(Flow &rec, Packet &pkt){
+int MQTTPlugin::pre_update(Flow& rec, Packet& pkt)
+{
     const char* payload = reinterpret_cast<const char*>(pkt.payload);
     RecordExt* ext = rec.get_extension(RecordExtMQTT::REGISTERED_ID);
     if (ext == nullptr) {
         return 0;
-    }else{
+    } else {
         parse_mqtt(payload, pkt.payload_len, static_cast<RecordExtMQTT*>(ext));
     }
     return 0;
 }
 
 /**
- * \brief Read variable integer as defined in http://docs.oasis-open.org/mqtt/mqtt/v3.1.1/mqtt-v3.1.1.html.
- * \param [in] data Pointer to IP payload.
- * \param [in] payload_len IP payload length.
- * \param [in] last_byte Next after last read byte.
- * \return Pair of read integer and bool. Bool is false in case read was unsuccessful.
+ * \brief Read variable integer as defined in
+ * http://docs.oasis-open.org/mqtt/mqtt/v3.1.1/mqtt-v3.1.1.html. \param [in] data Pointer to IP
+ * payload. \param [in] payload_len IP payload length. \param [in] last_byte Next after last read
+ * byte. \return Pair of read integer and bool. Bool is false in case read was unsuccessful.
  */
-std::pair<uint32_t, bool> MQTTPlugin::read_variable_int(const char* data, int payload_len, uint32_t& last_byte)const noexcept{
+std::pair<uint32_t, bool>
+MQTTPlugin::read_variable_int(const char* data, int payload_len, uint32_t& last_byte) const noexcept
+{
     uint32_t res = 0;
     bool next;
-    for( next = true; next  && last_byte < (uint32_t)payload_len; last_byte++){
+    for (next = true; next && last_byte < (uint32_t) payload_len; last_byte++) {
         res <<= 8;
         res |= data[last_byte];
         next = (data[last_byte] & 0b1000'0000);
     }
-    return last_byte == (uint32_t)payload_len && next ? std::make_pair(0u, false) : std::make_pair(res, true);
+    return last_byte == (uint32_t) payload_len && next ? std::make_pair(0u, false)
+                                                       : std::make_pair(res, true);
 }
 
 /**
- * \brief Read utf8 encoded string as defined in http://docs.oasis-open.org/mqtt/mqtt/v3.1.1/mqtt-v3.1.1.html.
- * \param [in] data Pointer to IP payload.
- * \param [in] payload_len IP payload length.
- * \param [in] last_byte Next after last read byte.
- * \return Tuple of read string, its length and bool. Bool is false in case read was unsuccessful.
+ * \brief Read utf8 encoded string as defined in
+ * http://docs.oasis-open.org/mqtt/mqtt/v3.1.1/mqtt-v3.1.1.html. \param [in] data Pointer to IP
+ * payload. \param [in] payload_len IP payload length. \param [in] last_byte Next after last read
+ * byte. \return Tuple of read string, its length and bool. Bool is false in case read was
+ * unsuccessful.
  */
-std::tuple<uint32_t, std::string_view, bool> MQTTPlugin::read_utf8_string(const char* data, int payload_len, uint32_t& last_byte) const noexcept{
-    if (last_byte + 2 >= (uint32_t)payload_len)
+std::tuple<uint32_t, std::string_view, bool>
+MQTTPlugin::read_utf8_string(const char* data, int payload_len, uint32_t& last_byte) const noexcept
+{
+    if (last_byte + 2 >= (uint32_t) payload_len)
         return {0, {}, false};
-    uint16_t string_length = ntohs(*(uint16_t*)&data[last_byte]);
+    uint16_t string_length = ntohs(*(uint16_t*) &data[last_byte]);
     last_byte += 2;
-    if (last_byte + string_length >= (uint32_t)payload_len)
+    if (last_byte + string_length >= (uint32_t) payload_len)
         return {0, {}, false};
     return {string_length, std::string_view(&data[last_byte], string_length), true};
 }
@@ -98,12 +108,13 @@ std::tuple<uint32_t, std::string_view, bool> MQTTPlugin::read_utf8_string(const
  * \param [in,out] rec Record to write MQTT data in.
  * \return True if buffer contains set of valid mqtt packets.
  */
-bool MQTTPlugin::parse_mqtt(const char* data, int payload_len, RecordExtMQTT* rec) noexcept{
+bool MQTTPlugin::parse_mqtt(const char* data, int payload_len, RecordExtMQTT* rec) noexcept
+{
     if (payload_len <= 0)
         return false;
     uint32_t last_byte = 0;
     // Each tcp segment may contain more MQTT packets
-    while(last_byte < (uint32_t)payload_len) {
+    while (last_byte < (uint32_t) payload_len) {
         uint8_t type, flags;
         type = flags = data[last_byte++];
         type >>= 4;
@@ -119,15 +130,15 @@ bool MQTTPlugin::parse_mqtt(const char* data, int payload_len, RecordExtMQTT* re
         auto first_byte_after_payload = remaining_length + last_byte;
         // Connect packet
         if (type == 1) {
-            if (!has_mqtt_protocol_name(data, payload_len)){
+            if (!has_mqtt_protocol_name(data, payload_len)) {
                 if constexpr (debug_mqtt)
                     std::cout << "Connection packet doesn't have MQTT label" << std::endl;
                 return false;
             }
             last_byte += 6; // Skip "MQTT" label(and its 2-byte length)
             rec->version = data[last_byte++];
-            //Only MQTT v3.1.1 and v5.0 are supported
-            if (rec->version != 4 && rec->version != 5){
+            // Only MQTT v3.1.1 and v5.0 are supported
+            if (rec->version != 4 && rec->version != 5) {
                 if constexpr (debug_mqtt)
                     std::cout << "Unsupported mqtt version" << std::endl;
                 return false;
@@ -163,62 +174,35 @@ bool MQTTPlugin::parse_mqtt(const char* data, int payload_len, RecordExtMQTT* re
         else if (type == 14) {
             flow_flush = true;
         }
-        // Read packet identifier
-        /*if ( (rec->type >= 3 && rec->type <= 11) || (rec->type == 3 && ((rec->flags >> 1) & 0b11)!= 0)){
-            rec->id = *((const uint16_t*)(&data[last_byte])); last_byte += 2;
-        }*/
-
-        // Read properties (only for MQTT v5.0)
-        /*if (rec->type <= 11 || rec->type >= 14){
-            rec->property_length = read_variable_int(data, payload_len, last_byte);
-            read_properties(data, payload_len, last_byte, rec);
-        }*/
 
         last_byte = first_byte_after_payload; // Skip rest of payload
     }
     return true;
 }
 
-int MQTTPlugin::post_update(Flow &rec, const Packet &pkt){
-    if (flow_flush){
+int MQTTPlugin::post_update(Flow& rec, const Packet& pkt)
+{
+    if (flow_flush) {
         flow_flush = false;
         return FLOW_FLUSH;
     }
     return 0;
 }
 
-void MQTTPlugin::pre_export(Flow &rec){
-    if constexpr (debug_mqtt){
-        RecordExtMQTT* ext = static_cast<RecordExtMQTT*>(rec.get_extension(RecordExtMQTT::REGISTERED_ID));
-        if (ext == nullptr)
-            return;
-        /*std::cout << "MQTT Exports: type cumulative = " << std::to_string(ext->type_cumulative)
-                  << ", version = " << std::to_string(ext->version) << ", con_flags = "
-                  << std::to_string(ext->connection_flags) << ",keep_alive = "
-                  << std::to_string(ext->keep_alive)<< ",\nsession_present= "
-                  << std::to_string(ext->session_present_flag) << ", last return code= "
-                  << std::to_string(ext->last_connect_return_code) << ", publish flags= "
-                  << std::to_string(ext->publish_flags) << ",\npublished topics: ";
-        for(auto it = ext->topics.begin(); it != ext->topics.end(); it++)
-            std::cout << (it == ext->topics.begin() ? "" : ", ") << *it;
-        std::cout << std::endl;*/
-    }
-    return;
-}
-
 /**
  * \brief Parse buffer to check if it contains MQTT packets.
  * \param [in] data Pointer to IP payload.
  * \param [in] payload_len IP payload length.
  * \return True if buffer starts with MQTT label as part of connection mqtt packet.
  */
-bool MQTTPlugin::has_mqtt_protocol_name(const char* data, int payload_len) const noexcept{
+bool MQTTPlugin::has_mqtt_protocol_name(const char* data, int payload_len) const noexcept
+{
     if (payload_len <= 1)
         return false;
     auto pos = 1u;
-    if (auto [_, success] = read_variable_int(data,payload_len, pos); !success)
+    if (auto [_, success] = read_variable_int(data, payload_len, pos); !success)
         return false;
-    auto [string_length, str, success] = read_utf8_string(data,payload_len, pos);
+    auto [string_length, str, success] = read_utf8_string(data, payload_len, pos);
     return success && str == "MQTT";
 }
 
@@ -228,16 +212,17 @@ void MQTTPlugin::add_ext_mqtt(const char* data, int payload_len, Flow& flow)
         recPrealloc = new RecordExtMQTT();
     }
     if (!parse_mqtt(data, payload_len, recPrealloc))
-        return ;
+        return;
     flow.add_extension(recPrealloc);
     recPrealloc = nullptr;
 }
 
-void MQTTPlugin::init(const char *params){
+void MQTTPlugin::init(const char* params)
+{
     MQTTOptionsParser parser;
     try {
         parser.parse(params);
-    } catch (ParserError &e) {
+    } catch (ParserError& e) {
         throw PluginError(e.what());
     }
     maximal_topic_count = parser.m_maximal_topic_count;