Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ipfix plugin: Add Lz4 compression #179

Merged
merged 6 commits into from
Aug 28, 2024
Merged

Ipfix plugin: Add Lz4 compression #179

merged 6 commits into from
Aug 28, 2024

Conversation

BonnyAD9
Copy link
Contributor

No description provided.

@cejkato2
Copy link
Contributor

cejkato2 commented Jun 4, 2024

It would be perfect to have a switch in configure to be able to disable this feature during the build.

@SiskaPavel SiskaPavel marked this pull request as draft June 11, 2024 08:04
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 19.87578% with 129 lines in your changes missing coverage. Please review.

Project coverage is 40.53%. Comparing base (5ba318c) to head (a72a1b8).
Report is 7 commits behind head on master.

Files Patch % Lines
output/ipfix.cpp 19.35% 119 Missing and 6 partials ⚠️
output/ipfix.hpp 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   40.80%   40.53%   -0.28%     
==========================================
  Files         104      104              
  Lines        9956    10102     +146     
  Branches     1467     1493      +26     
==========================================
+ Hits         4063     4095      +32     
- Misses       5033     5143     +110     
- Partials      860      864       +4     
Flag Coverage Δ
tests 40.53% <19.87%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

output/ipfix.hpp Outdated Show resolved Hide resolved
@SiskaPavel SiskaPavel marked this pull request as ready for review August 28, 2024 11:52
@SiskaPavel SiskaPavel changed the title TCP plugin: Lz4 compression Ipfix plugin: Add Lz4 compression Aug 28, 2024
@SiskaPavel SiskaPavel merged commit 3717722 into master Aug 28, 2024
5 checks passed
@SiskaPavel SiskaPavel deleted the lz4-compression branch August 28, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants