-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QUIC: Extract more QUIC flow details #194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jonas, Thank you very much for your effort! I have small comments on your contribution. Besides, I would like to ask you about code formatting according to the .clang-format file in the repository root. Any modern IDE should understand this code formatting.
This include the following improvements: - Fix order of processing CID information - Fix detection of QUIC sni - Store DCID from first Initial and Retry packet for decryption, in case the connection does not begin with an Initial incl. the TLS client hello. - Version negotiation: extract CID fields - Scan for QUIC packets in the entire flow. Before we only checked the first packet. But this is problematic when an unknown QUIC version is used in the first packet. - Add all known QUIC versions and respective salts (Adds Facebook versions, picoquic and QUICv2 salts) - Add extraction of TLS extensions in Client Hello. This includes the extraction of the TLS extension type, length and payload. - Increase QUIC token size. - Update authors and date - Update README - Code cleanup, refector get_API
We assume QUIC version 1 if we have no knowledge about the spoken QUIC version.
Hello, |
Modify this if statement:
|
I applied the commit and modified that condition to get rid of the compiler warning. I also changed part or the retry code, to only act upon the first retry packet. |
We extend ipfixprobe's quic module by extracting the following additional QUIC meta information:
Additional improvements:
Limitations: