Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update intel KGOs to v004. #100

Merged
merged 18 commits into from
Sep 17, 2024
Merged

Update intel KGOs to v004. #100

merged 18 commits into from
Sep 17, 2024

Conversation

alejandrobodas
Copy link
Collaborator

Integration tests for intel compilers fail due to compiler upgrades or other changes in external dependencies (https://github.com/CFMIP/COSPv2.0/actions/runs/10736182713). This PR updates the KGOs,

@alejandrobodas
Copy link
Collaborator Author

@dustinswales please can you review this change? We need this fixed in order to review and merge PR #99. Thanks!

@RobertPincus
Copy link
Contributor

@alejandrobodas It would be nice to attach to this PR some documentation/plot/description of how much the KGOs have changed, don't you think?

@alejandrobodas
Copy link
Collaborator Author

@alejandrobodas It would be nice to attach to this PR some documentation/plot/description of how much the KGOs have changed, don't you think?

Yes, I'll do that.

@dustinswales
Copy link
Contributor

@alejandrobodas These changes look good to me. Are you going to fix the Intel container w/ this PR?
@RobertPincus See the comparison step the CI logs.

@alejandrobodas
Copy link
Collaborator Author

@dustinswales yes, but in the process I've noticed that something is wrong with the python script that automatically produces the plots when the tests fail so I'm trying to fix that too. If I can't fix the issue quickly, I'll deal with that in a new PR.

@alejandrobodas
Copy link
Collaborator Author

alejandrobodas commented Sep 16, 2024

cosp2_output um_global ifort kgo v003 nc cfadDbze94
cosp2_output um_global ifort kgo v004 nc cfadDbze94

These figures show that the differences in dbze94 (order 10-4 or smaller) are negligible. Top figure is v003 and bottom figure is the new v004 KGO for ifort.

@dustinswales @RobertPincus I've finished with this change, so please approve if you're happy with the changes. Thanks!

Copy link
Contributor

@dustinswales dustinswales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alejandrobodas Changes look to be itsy-bitsy to me. Thanks for making this changes, an updating the Intel CI!!

@alejandrobodas alejandrobodas merged commit 3fefa6c into master Sep 17, 2024
10 checks passed
@alejandrobodas alejandrobodas deleted the kgo_v004 branch September 17, 2024 12:34
@alejandrobodas
Copy link
Collaborator Author

Thanks @dustinswales , changes merged and branch deleted.

alejandrobodas added a commit that referenced this pull request Sep 17, 2024
Make rcfg_cloudsat a HEAP variable
Merging because the the errors are the same as the differences between v003 and v004 KGOs of the intel compilers, fixed in PR #100.
alejandrobodas added a commit that referenced this pull request Sep 17, 2024
…tions/upload-artifact-4.4.0

Bump actions/upload-artifact from 4.3.3 to 4.4.0
Errors in intel compilers tests caused fixed in PR #100.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants